Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1295)

Unified Diff: chrome/browser/extensions/webstore_installer.cc

Issue 11028131: Shift passage of FileStream in downloads system to be by scoped_ptr<>. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Incorporated Al's comments. Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/webstore_installer.cc
diff --git a/chrome/browser/extensions/webstore_installer.cc b/chrome/browser/extensions/webstore_installer.cc
index 2ac133295cc43a949fce937bb600255beb12846c..3d21a8942609cdd052f64bcaacbb794440c695b2 100644
--- a/chrome/browser/extensions/webstore_installer.cc
+++ b/chrome/browser/extensions/webstore_installer.cc
@@ -345,8 +345,9 @@ void WebstoreInstaller::StartDownload(const FilePath& file) {
return;
}
- content::DownloadSaveInfo save_info;
- save_info.file_path = file;
+ scoped_ptr<content::DownloadSaveInfo> save_info(
+ new content::DownloadSaveInfo());
+ save_info->file_path = file;
// The download url for the given extension is contained in |download_url_|.
// We will navigate the current tab to this url to start the download. The
@@ -355,7 +356,7 @@ void WebstoreInstaller::StartDownload(const FilePath& file) {
download_util::INITIATED_BY_WEBSTORE_INSTALLER);
scoped_ptr<DownloadUrlParameters> params(
DownloadUrlParameters::FromWebContents(
- controller_->GetWebContents(), download_url_, save_info));
+ controller_->GetWebContents(), download_url_, save_info.Pass()));
if (controller_->GetActiveEntry())
params->set_referrer(
content::Referrer(controller_->GetActiveEntry()->GetURL(),
« no previous file with comments | « chrome/browser/extensions/api/downloads/downloads_api.cc ('k') | chrome/browser/plugins/plugin_installer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698