Shift passage of FileStream in downloads system to be by scoped_ptr<>.

content/browser/download/download_manager_impl.cc

Index: content/browser/download/download_manager_impl.cc
diff --git a/content/browser/download/download_manager_impl.cc b/content/browser/download/download_manager_impl.cc
index 458f5ca657fdafd7307551b05cf7e03e62c437b8..13dc25b380cd38973ecf90611bec9b88ccb1d64c 100644
--- a/content/browser/download/download_manager_impl.cc
+++ b/content/browser/download/download_manager_impl.cc
@@ -75,7 +75,7 @@ class SavePageData : public base::SupportsUserData::Data {
 
 const char SavePageData::kKey[] = "DownloadItem SavePageData";
 
-void BeginDownload(content::DownloadUrlParameters* params) {
+void BeginDownload(scoped_ptr<content::DownloadUrlParameters> params) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
   // ResourceDispatcherHost{Base} is-not-a URLRequest::Delegate, and
   // DownloadUrlParameters can-not include resource_dispatcher_host_impl.h, so
@@ -116,7 +116,7 @@ void BeginDownload(content::DownloadUrlParameters* params) {
       params->render_process_host_id(),
       params->render_view_host_routing_id(),
       params->prefer_cache(),
-      params->save_info(),
+      params->GetSaveInfo(),            // Nulls params internal copy.

[benjhayden, 2012/10/11 19:41:12]

This comment belongs in d_u_p.h, not here. |params| is a scoped_ptr here, so its
days (cpu cycles?) are numbered anyway.

[Randy Smith (Not in Mondays), 2012/10/15 18:56:32]

Ok, but it is already there, and that behavior might be (is) strange from the
callers perspective.  But Done.  (The obvious fix for this is to merge
DownloadSaveInfo into DUP as you suggested).

       params->callback());
 }
 
@@ -792,7 +792,7 @@ void DownloadManagerImpl::DownloadUrl(
     DCHECK(params->method() == "POST");
   }
   BrowserThread::PostTask(BrowserThread::IO, FROM_HERE, base::Bind(
-      &BeginDownload, base::Owned(params.release())));
+      &BeginDownload, base::Passed(params.Pass())));
 }
 
 void DownloadManagerImpl::AddObserver(Observer* observer) {