Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Unified Diff: content/browser/download/download_file_factory.cc

Issue 11028131: Shift passage of FileStream in downloads system to be by scoped_ptr<>. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Removed blank line. Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/download/download_file_factory.cc
diff --git a/content/browser/download/download_file_factory.cc b/content/browser/download/download_file_factory.cc
index 819137f44f7a54c3a070b73049e4d89d6a64ddb7..4affc074c3438578e59cb74a2da215d454386120 100644
--- a/content/browser/download/download_file_factory.cc
+++ b/content/browser/download/download_file_factory.cc
@@ -12,14 +12,18 @@ namespace content {
DownloadFileFactory::~DownloadFileFactory() {}
DownloadFile* DownloadFileFactory::CreateFile(
- DownloadCreateInfo* info,
+ scoped_ptr<DownloadCreateInfo> info,
scoped_ptr<content::ByteStreamReader> stream,
DownloadManager* download_manager,
bool calculate_hash,
const net::BoundNetLog& bound_net_log) {
+ // Ownership will be taken by DownloadFileImpl.
benjhayden 2012/10/11 19:41:12 So why not make DFI take a scoped_ptr?
Randy Smith (Not in Mondays) 2012/10/15 18:56:32 You know, as I went through this CL, I *knew* you
+ DownloadRequestHandle* request_handle(
+ new DownloadRequestHandle(info->request_handle));
+
return new DownloadFileImpl(
- info, stream.Pass(), new DownloadRequestHandle(info->request_handle),
- download_manager, calculate_hash,
+ info.Pass(), stream.Pass(), request_handle, download_manager,
+ calculate_hash,
scoped_ptr<content::PowerSaveBlocker>(
new content::PowerSaveBlocker(
content::PowerSaveBlocker::kPowerSaveBlockPreventAppSuspension,

Powered by Google App Engine
This is Rietveld 408576698