Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11028125: Remove legacy draggable region code and refactor to share common draggable region code (Closed)

Created:
8 years, 2 months ago by jianli
Modified:
8 years, 2 months ago
CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org, tfarina, jeremya+watch_chromium.org, dcheng, Aaron Boodman, darin-cc_chromium.org
Visibility:
Public.

Description

Remove legacy draggable region code and refactor to share common draggable region code BUG=none TEST=manual test by verifying new draggable region syntax works Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=162224

Patch Set 1 : Patch #

Total comments: 2

Patch Set 2 : Fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -173 lines) Patch
M chrome/browser/ui/cocoa/extensions/shell_window_cocoa.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/shell_window_cocoa.mm View 1 1 chunk +1 line, -30 lines 0 comments Download
M chrome/browser/ui/extensions/native_shell_window.h View 1 1 chunk +1 line, -7 lines 0 comments Download
M chrome/browser/ui/extensions/shell_window.h View 1 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/extensions/shell_window.cc View 1 3 chunks +20 lines, -18 lines 0 comments Download
M chrome/browser/ui/gtk/extensions/shell_window_gtk.h View 1 4 chunks +3 lines, -6 lines 0 comments Download
M chrome/browser/ui/gtk/extensions/shell_window_gtk.cc View 1 4 chunks +4 lines, -48 lines 0 comments Download
M chrome/browser/ui/views/extensions/shell_window_views.h View 1 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/extensions/shell_window_views.cc View 1 1 chunk +1 line, -46 lines 0 comments Download
M chrome/common/extensions/draggable_region.h View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/common/extensions/extension_messages.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/renderer/extensions/extension_helper.cc View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
jianli
8 years, 2 months ago (2012-10-10 23:25:18 UTC) #1
Ben Goodger (Google)
http://codereview.chromium.org/11028125/diff/8001/chrome/browser/ui/extensions/native_shell_window.h File chrome/browser/ui/extensions/native_shell_window.h (right): http://codereview.chromium.org/11028125/diff/8001/chrome/browser/ui/extensions/native_shell_window.h#newcode52 chrome/browser/ui/extensions/native_shell_window.h:52: bool frameless_; since this is an interface, you can't ...
8 years, 2 months ago (2012-10-12 16:24:41 UTC) #2
jianli
http://codereview.chromium.org/11028125/diff/8001/chrome/browser/ui/extensions/native_shell_window.h File chrome/browser/ui/extensions/native_shell_window.h (right): http://codereview.chromium.org/11028125/diff/8001/chrome/browser/ui/extensions/native_shell_window.h#newcode52 chrome/browser/ui/extensions/native_shell_window.h:52: bool frameless_; On 2012/10/12 16:24:41, Ben Goodger (Google) wrote: ...
8 years, 2 months ago (2012-10-12 21:39:40 UTC) #3
jeremya
lgtm
8 years, 2 months ago (2012-10-14 23:11:11 UTC) #4
Ben Goodger (Google)
lgtm
8 years, 2 months ago (2012-10-16 17:53:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jianli@chromium.org/11028125/24001
8 years, 2 months ago (2012-10-16 18:09:37 UTC) #6
commit-bot: I haz the power
8 years, 2 months ago (2012-10-16 20:07:20 UTC) #7 
Change committed as 162224

Powered by Google App Engine
This is Rietveld 408576698