Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(754)

Side by Side Diff: src/arm/macro-assembler-arm.h

Issue 11028115: DoNumberTagD performance improvement (Closed) Base URL: git://github.com/v8/v8.git@master
Patch Set: Fix remaining code review comments Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/arm/lithium-codegen-arm.cc ('k') | src/arm/macro-assembler-arm.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
61 // Return the pointer to the allocated already tagged as a heap object. 61 // Return the pointer to the allocated already tagged as a heap object.
62 TAG_OBJECT = 1 << 0, 62 TAG_OBJECT = 1 << 0,
63 // The content of the result register already contains the allocation top in 63 // The content of the result register already contains the allocation top in
64 // new space. 64 // new space.
65 RESULT_CONTAINS_TOP = 1 << 1, 65 RESULT_CONTAINS_TOP = 1 << 1,
66 // Specify that the requested size of the space to allocate is specified in 66 // Specify that the requested size of the space to allocate is specified in
67 // words instead of bytes. 67 // words instead of bytes.
68 SIZE_IN_WORDS = 1 << 2 68 SIZE_IN_WORDS = 1 << 2
69 }; 69 };
70 70
71 // Flags used for AllocateHeapNumber
72 enum TaggingMode {
73 // Tag the result.
74 TAG_RESULT,
75 // Don't tag
76 DONT_TAG_RESULT
77 };
71 78
72 // Flags used for the ObjectToDoubleVFPRegister function. 79 // Flags used for the ObjectToDoubleVFPRegister function.
73 enum ObjectToDoubleFlags { 80 enum ObjectToDoubleFlags {
74 // No special flags. 81 // No special flags.
75 NO_OBJECT_TO_DOUBLE_FLAGS = 0, 82 NO_OBJECT_TO_DOUBLE_FLAGS = 0,
76 // Object is known to be a non smi. 83 // Object is known to be a non smi.
77 OBJECT_NOT_SMI = 1 << 0, 84 OBJECT_NOT_SMI = 1 << 0,
78 // Don't load NaNs or infinities, branch to the non number case instead. 85 // Don't load NaNs or infinities, branch to the non number case instead.
79 AVOID_NANS_AND_INFINITIES = 1 << 1 86 AVOID_NANS_AND_INFINITIES = 1 << 1
80 }; 87 };
(...skipping 643 matching lines...) Expand 10 before | Expand all | Expand 10 after
724 Register scratch2, 731 Register scratch2,
725 Label* gc_required); 732 Label* gc_required);
726 733
727 // Allocates a heap number or jumps to the gc_required label if the young 734 // Allocates a heap number or jumps to the gc_required label if the young
728 // space is full and a scavenge is needed. All registers are clobbered also 735 // space is full and a scavenge is needed. All registers are clobbered also
729 // when control continues at the gc_required label. 736 // when control continues at the gc_required label.
730 void AllocateHeapNumber(Register result, 737 void AllocateHeapNumber(Register result,
731 Register scratch1, 738 Register scratch1,
732 Register scratch2, 739 Register scratch2,
733 Register heap_number_map, 740 Register heap_number_map,
734 Label* gc_required); 741 Label* gc_required,
742 TaggingMode tagging_mode = TAG_RESULT);
735 void AllocateHeapNumberWithValue(Register result, 743 void AllocateHeapNumberWithValue(Register result,
736 DwVfpRegister value, 744 DwVfpRegister value,
737 Register scratch1, 745 Register scratch1,
738 Register scratch2, 746 Register scratch2,
739 Register heap_number_map, 747 Register heap_number_map,
740 Label* gc_required); 748 Label* gc_required);
741 749
742 // Copies a fixed number of fields of heap objects from src to dst. 750 // Copies a fixed number of fields of heap objects from src to dst.
743 void CopyFields(Register dst, Register src, RegList temps, int field_count); 751 void CopyFields(Register dst, Register src, RegList temps, int field_count);
744 752
(...skipping 657 matching lines...) Expand 10 before | Expand all | Expand 10 after
1402 #define __FILE_LINE__ __FILE__ ":" CODE_COVERAGE_TOSTRING(__LINE__) 1410 #define __FILE_LINE__ __FILE__ ":" CODE_COVERAGE_TOSTRING(__LINE__)
1403 #define ACCESS_MASM(masm) masm->stop(__FILE_LINE__); masm-> 1411 #define ACCESS_MASM(masm) masm->stop(__FILE_LINE__); masm->
1404 #else 1412 #else
1405 #define ACCESS_MASM(masm) masm-> 1413 #define ACCESS_MASM(masm) masm->
1406 #endif 1414 #endif
1407 1415
1408 1416
1409 } } // namespace v8::internal 1417 } } // namespace v8::internal
1410 1418
1411 #endif // V8_ARM_MACRO_ASSEMBLER_ARM_H_ 1419 #endif // V8_ARM_MACRO_ASSEMBLER_ARM_H_
OLDNEW
« no previous file with comments | « src/arm/lithium-codegen-arm.cc ('k') | src/arm/macro-assembler-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698