Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Unified Diff: chrome/browser/prerender/prerender_tab_helper.cc

Issue 11028037: Fix prerender histograms for multiple prerender case. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: further remediation Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/prerender/prerender_tab_helper.cc
diff --git a/chrome/browser/prerender/prerender_tab_helper.cc b/chrome/browser/prerender/prerender_tab_helper.cc
index 0a973caa6ec7b55f8eb0072214ffb902d7a961b5..550642b4013d2b58509fbb36e39966555d822229 100644
--- a/chrome/browser/prerender/prerender_tab_helper.cc
+++ b/chrome/browser/prerender/prerender_tab_helper.cc
@@ -89,8 +89,8 @@ class PrerenderTabHelper::PixelStats {
PrerenderManager* prerender_manager =
tab_helper_->MaybeGetPrerenderManager();
if (prerender_manager) {
- prerender_manager->histograms()->RecordFractionPixelsFinalAtSwapin(
- CompareBitmaps(bitmap_.get(), bitmap.get()));
+ prerender_manager->RecordFractionPixelsFinalAtSwapin(
+ web_contents, CompareBitmaps(bitmap_.get(), bitmap.get()));
}
bitmap_.reset();
bitmap_web_contents_ = NULL;
@@ -144,7 +144,7 @@ void PrerenderTabHelper::ProvisionalChangeToMainFrameUrl(
PrerenderManager* prerender_manager = MaybeGetPrerenderManager();
if (!prerender_manager)
return;
- if (prerender_manager->IsWebContentsPrerendering(web_contents()))
+ if (prerender_manager->IsWebContentsPrerendering(web_contents(), NULL))
return;
prerender_manager->MarkWebContentsAsNotPrerendered(web_contents());
}
@@ -161,7 +161,7 @@ void PrerenderTabHelper::DidCommitProvisionalLoadForFrame(
PrerenderManager* prerender_manager = MaybeGetPrerenderManager();
if (!prerender_manager)
return;
- if (prerender_manager->IsWebContentsPrerendering(web_contents()))
+ if (prerender_manager->IsWebContentsPrerendering(web_contents(), NULL))
return;
prerender_manager->RecordNavigation(validated_url);
}
@@ -220,14 +220,14 @@ bool PrerenderTabHelper::IsPrerendering() {
PrerenderManager* prerender_manager = MaybeGetPrerenderManager();
if (!prerender_manager)
return false;
- return prerender_manager->IsWebContentsPrerendering(web_contents());
+ return prerender_manager->IsWebContentsPrerendering(web_contents(), NULL);
}
bool PrerenderTabHelper::IsPrerendered() {
PrerenderManager* prerender_manager = MaybeGetPrerenderManager();
if (!prerender_manager)
return false;
- return prerender_manager->IsWebContentsPrerendered(web_contents());
+ return prerender_manager->IsWebContentsPrerendered(web_contents(), NULL);
}
void PrerenderTabHelper::PrerenderSwappedIn() {
@@ -239,7 +239,7 @@ void PrerenderTabHelper::PrerenderSwappedIn() {
web_contents(), url_);
PrerenderManager* prerender_manager = MaybeGetPrerenderManager();
if (prerender_manager)
- prerender_manager->histograms()->RecordFractionPixelsFinalAtSwapin(1.0);
+ prerender_manager->RecordFractionPixelsFinalAtSwapin(web_contents(), 1.0);
} else {
// If we have not finished loading yet, record the actual load start, and
// rebase the start time to now.

Powered by Google App Engine
This is Rietveld 408576698