Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1424)

Unified Diff: chrome/browser/prerender/prerender_local_predictor.cc

Issue 11028037: Fix prerender histograms for multiple prerender case. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: ... fix window logic Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/prerender/prerender_local_predictor.cc
diff --git a/chrome/browser/prerender/prerender_local_predictor.cc b/chrome/browser/prerender/prerender_local_predictor.cc
index 573ea62e7ea17770f900f87d844998e3702d2767..a391903954b1ee30f571ad28767e9d248a1c7e2b 100644
--- a/chrome/browser/prerender/prerender_local_predictor.cc
+++ b/chrome/browser/prerender/prerender_local_predictor.cc
@@ -9,6 +9,7 @@
#include <map>
#include <set>
+#include "base/metrics/field_trial.h"
#include "base/metrics/histogram.h"
#include "base/timer.h"
#include "chrome/browser/prerender/prerender_histograms.h"
@@ -200,9 +201,12 @@ void PrerenderLocalPredictor::OnAddVisit(const history::BriefVisitInfo& info) {
if (current_prerender_.get() &&
current_prerender_->url_id == info.url_id &&
IsPrerenderStillValid(current_prerender_.get())) {
- prerender_manager_->histograms()->RecordLocalPredictorTimeUntilUsed(
+ UMA_HISTOGRAM_CUSTOM_TIMES(
+ "Prerender.LocalPredictorTimeUntilUsed",
GetCurrentTime() - current_prerender_->actual_start_time,
- base::TimeDelta::FromMilliseconds(kMaxLocalPredictionTimeMs));
+ base::TimeDelta::FromMilliseconds(10),
+ base::TimeDelta::FromMilliseconds(kMaxLocalPredictionTimeMs),
+ 50);
last_swapped_in_prerender_.reset(current_prerender_.release());
RecordEvent(EVENT_ADD_VISIT_PRERENDER_IDENTIFIED);
}
@@ -370,17 +374,23 @@ void PrerenderLocalPredictor::OnPLTEventForURL(const GURL& url,
if (!prerender.get())
return;
if (IsPrerenderStillValid(prerender.get())) {
+ UMA_HISTOGRAM_CUSTOM_TIMES("Prerender.SimulatedLocalBrowsingBaselinePLT",
+ page_load_time,
+ base::TimeDelta::FromMilliseconds(10),
+ base::TimeDelta::FromSeconds(60),
+ 100);
+
base::TimeDelta prerender_age = GetCurrentTime() - prerender->start_time;
- prerender_manager_->histograms()->RecordSimulatedLocalBrowsingBaselinePLT(
- page_load_time, url);
if (prerender_age > page_load_time) {
base::TimeDelta new_plt;
if (prerender_age < 2 * page_load_time)
new_plt = 2 * page_load_time - prerender_age;
- prerender_manager_->histograms()->RecordSimulatedLocalBrowsingPLT(
- new_plt, url);
+ UMA_HISTOGRAM_CUSTOM_TIMES("Prerender.SimulatedLocalBrowsingBaselinePLT",
+ new_plt,
+ base::TimeDelta::FromMilliseconds(10),
+ base::TimeDelta::FromSeconds(60),
+ 100);
}
-
}
}
@@ -394,7 +404,10 @@ bool PrerenderLocalPredictor::IsPrerenderStillValid(
void PrerenderLocalPredictor::RecordEvent(PrerenderLocalPredictor::Event event)
const {
- prerender_manager_->histograms()->RecordLocalPredictorEvent(event);
+ UMA_HISTOGRAM_ENUMERATION(
+ base::FieldTrial::MakeName("Prerender.LocalPredictorTimeUntilUsed",
+ "Prerender"),
+ event, PrerenderLocalPredictor::EVENT_MAX_VALUE);
mmenke 2012/10/12 17:59:03 This used to call RecordLocalPredictorEvent, not R
gavinp 2012/10/13 13:48:09 Indeed. Of the four histograms I moved to this fil
mmenke 2012/10/15 15:28:28 Hmm...Looks like two, to me (Which are both now fi
}
bool PrerenderLocalPredictor::DoesPrerenderMatchPLTRecord(

Powered by Google App Engine
This is Rietveld 408576698