| Index: chrome/common/json_pref_store.h
|
| diff --git a/chrome/common/json_pref_store.h b/chrome/common/json_pref_store.h
|
| index 7ceb7dad2ac0c472e51a1405e58861e6fd6ad93a..b520c4278573d120eb029daac417ac9033299cfb 100644
|
| --- a/chrome/common/json_pref_store.h
|
| +++ b/chrome/common/json_pref_store.h
|
| @@ -18,7 +18,8 @@
|
|
|
| namespace base {
|
| class DictionaryValue;
|
| -class MessageLoopProxy;
|
| +class SequencedWorkerPool;
|
| +class SequencedTaskRunner;
|
| class Value;
|
| }
|
|
|
| @@ -28,10 +29,19 @@ class FilePath;
|
| class JsonPrefStore : public PersistentPrefStore,
|
| public ImportantFileWriter::DataSerializer {
|
| public:
|
| - // |file_message_loop_proxy| is the MessageLoopProxy for a thread on which
|
| - // file I/O can be done.
|
| - JsonPrefStore(const FilePath& pref_filename,
|
| - base::MessageLoopProxy* file_message_loop_proxy);
|
| + // Returns instance of SequencedTaskRunner which guarantees that file
|
| + // operations on the same file will be executed in sequenced order.
|
| + static scoped_refptr<base::SequencedTaskRunner> GetTaskRunnerForFile(
|
| + const FilePath& pref_filename,
|
| + base::SequencedWorkerPool* worker_pool);
|
| +
|
| + // Creates an instance JsonPrefStore for a given |pref_filename| that will
|
| + // perform all file I/O operations on |sequenced_task_runner|.
|
| + // |sequenced_task_runner| must be a shutdown-blocking task runner, ideally
|
| + // created by GetTaskRunnerForFile() method above.
|
| + static JsonPrefStore* Create(
|
| + const FilePath& pref_filename,
|
| + base::SequencedTaskRunner* sequenced_task_runner);
|
|
|
| // PrefStore overrides:
|
| virtual ReadResult GetValue(const std::string& key,
|
| @@ -63,13 +73,17 @@ class JsonPrefStore : public PersistentPrefStore,
|
| void OnFileRead(base::Value* value_owned, PrefReadError error, bool no_dir);
|
|
|
| private:
|
| + // |sequenced_task_runner| is a SequencedTaskRunner on which file I/O will be
|
| + // run.
|
| + JsonPrefStore(const FilePath& pref_filename,
|
| + base::SequencedTaskRunner* sequenced_task_runner);
|
| virtual ~JsonPrefStore();
|
|
|
| // ImportantFileWriter::DataSerializer overrides:
|
| virtual bool SerializeData(std::string* output) OVERRIDE;
|
|
|
| FilePath path_;
|
| - scoped_refptr<base::MessageLoopProxy> file_message_loop_proxy_;
|
| + const scoped_refptr<base::SequencedTaskRunner> sequenced_task_runner_;
|
|
|
| scoped_ptr<base::DictionaryValue> prefs_;
|
|
|
|
|