Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(532)

Unified Diff: chrome/browser/prefs/pref_service_unittest.cc

Issue 11027070: Moved JsonPrefStore to use SequencedWorkerPool (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/prefs/pref_service_unittest.cc
diff --git a/chrome/browser/prefs/pref_service_unittest.cc b/chrome/browser/prefs/pref_service_unittest.cc
index 4b4dfd72e3af2ebcd69f34af968f3de4b11cc5f8..c64768b36fc2ab4aa1163a376e6a5ac218cd710f 100644
--- a/chrome/browser/prefs/pref_service_unittest.cc
+++ b/chrome/browser/prefs/pref_service_unittest.cc
@@ -301,7 +301,7 @@ class PrefServiceUserFilePrefsTest : public testing::Test {
ScopedTempDir temp_dir_;
// The path to the directory where the test data is stored.
FilePath data_dir_;
- // A message loop that we can use as the file thread message loop.
+ // A message loop that we need for firing timers.
Mattias Nissler (ping if slow) 2012/10/22 17:28:21 It's not timers AFAICS.
zel 2012/10/24 02:20:11 Done.
MessageLoop message_loop_;
};
@@ -315,7 +315,7 @@ TEST_F(PrefServiceUserFilePrefsTest, PreserveEmptyValue) {
pref_file));
PrefServiceMockBuilder builder;
- builder.WithUserFilePrefs(pref_file, base::MessageLoopProxy::current());
+ builder.WithUserFilePrefs(pref_file, message_loop_.message_loop_proxy());
scoped_ptr<PrefService> prefs(builder.Create());
// Register testing prefs.
@@ -344,7 +344,7 @@ TEST_F(PrefServiceUserFilePrefsTest, PreserveEmptyValue) {
// Write to file.
prefs->CommitPendingWrite();
- MessageLoop::current()->RunAllPending();
+ message_loop_.RunAllPending();
// Compare to expected output.
FilePath golden_output_file =

Powered by Google App Engine
This is Rietveld 408576698