Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(675)

Unified Diff: chrome/browser/extensions/menu_manager_unittest.cc

Issue 11027070: Moved JsonPrefStore to use SequencedWorkerPool (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/menu_manager_unittest.cc
diff --git a/chrome/browser/extensions/menu_manager_unittest.cc b/chrome/browser/extensions/menu_manager_unittest.cc
index fc6049da9564bd4745f44664bde84d9d1f01b964..309f284c42414702c29b0c3f98313a86332b40d4 100644
--- a/chrome/browser/extensions/menu_manager_unittest.cc
+++ b/chrome/browser/extensions/menu_manager_unittest.cc
@@ -14,6 +14,7 @@
#include "chrome/browser/extensions/event_names.h"
#include "chrome/browser/extensions/event_router.h"
#include "chrome/browser/extensions/menu_manager.h"
+#include "chrome/browser/prefs/pref_service.h"
#include "chrome/browser/extensions/test_extension_prefs.h"
#include "chrome/common/chrome_notification_types.h"
#include "chrome/common/chrome_paths.h"
@@ -43,6 +44,15 @@ class MenuManagerTest : public testing::Test {
file_thread_(BrowserThread::FILE, &message_loop_),
manager_(&profile_),
next_id_(1) {
+ prefs_.reset(new TestExtensionPrefs(message_loop_.message_loop_proxy()));
+ }
+
+ ~MenuManagerTest() {
akalin 2012/10/19 02:00:51 destructor should be virtual
zel 2012/10/19 18:45:07 Removed.
+ }
+
+ virtual void TearDown() OVERRIDE {
+ prefs_->pref_service()->CommitPendingWrite();
+ MessageLoop::current()->RunAllPending();
}
// Returns a test item.
@@ -67,7 +77,7 @@ class MenuManagerTest : public testing::Test {
// Creates and returns a test Extension. The caller does *not* own the return
// value.
Extension* AddExtension(std::string name) {
- scoped_refptr<Extension> extension = prefs_.AddExtension(name);
+ scoped_refptr<Extension> extension = prefs_->AddExtension(name);
extensions_.push_back(extension);
return extension;
}
@@ -80,7 +90,7 @@ class MenuManagerTest : public testing::Test {
MenuManager manager_;
ExtensionList extensions_;
- TestExtensionPrefs prefs_;
+ scoped_ptr<TestExtensionPrefs> prefs_;
akalin 2012/10/19 02:00:51 as above, don't think this needs to be a scoped_pt
zel 2012/10/19 18:45:07 Done.
int next_id_;
private:

Powered by Google App Engine
This is Rietveld 408576698