Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Side by Side Diff: chrome/service/service_process_prefs_unittest.cc

Issue 11027070: Moved JsonPrefStore to use SequencedWorkerPool (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <string> 5 #include <string>
6 6
7 #include "base/message_loop.h" 7 #include "base/message_loop.h"
8 #include "base/message_loop_proxy.h" 8 #include "base/message_loop_proxy.h"
9 #include "base/scoped_temp_dir.h" 9 #include "base/scoped_temp_dir.h"
10 #include "base/threading/sequenced_worker_pool.h"
akalin 2012/10/19 23:12:21 remove this include
zel 2012/10/21 20:03:19 Done.
10 #include "chrome/service/service_process_prefs.h" 11 #include "chrome/service/service_process_prefs.h"
11 #include "testing/gmock/include/gmock/gmock.h" 12 #include "testing/gmock/include/gmock/gmock.h"
12 #include "testing/gtest/include/gtest/gtest.h" 13 #include "testing/gtest/include/gtest/gtest.h"
13 14
14 class ServiceProcessPrefsTest : public testing::Test { 15 class ServiceProcessPrefsTest : public testing::Test {
15 protected: 16 protected:
16 virtual void SetUp() { 17 virtual void SetUp() OVERRIDE {
17 message_loop_proxy_ = base::MessageLoopProxy::current();
18
19 ASSERT_TRUE(temp_dir_.CreateUniqueTempDir()); 18 ASSERT_TRUE(temp_dir_.CreateUniqueTempDir());
20 19
21 prefs_.reset(new ServiceProcessPrefs( 20 prefs_.reset(new ServiceProcessPrefs(
22 temp_dir_.path().AppendASCII("service_process_prefs.txt"), 21 temp_dir_.path().AppendASCII("service_process_prefs.txt"),
23 message_loop_proxy_.get())); 22 message_loop_.message_loop_proxy()));
23 }
24
25 virtual void TearDown() OVERRIDE {
26 prefs_.reset(NULL);
akalin 2012/10/19 23:12:21 you can just go ".reset();" (and I think that's th
zel 2012/10/21 20:03:19 Done.
24 } 27 }
25 28
26 // The path to temporary directory used to contain the test operations. 29 // The path to temporary directory used to contain the test operations.
27 ScopedTempDir temp_dir_; 30 ScopedTempDir temp_dir_;
28 // A message loop that we can use as the file thread message loop. 31 // A message loop that we need for timers.
29 MessageLoop message_loop_; 32 MessageLoop message_loop_;
30 scoped_refptr<base::MessageLoopProxy> message_loop_proxy_;
31 scoped_ptr<ServiceProcessPrefs> prefs_; 33 scoped_ptr<ServiceProcessPrefs> prefs_;
32 }; 34 };
33 35
34 // Test ability to retrieve prefs 36 // Test ability to retrieve prefs
35 TEST_F(ServiceProcessPrefsTest, RetrievePrefs) { 37 TEST_F(ServiceProcessPrefsTest, RetrievePrefs) {
36 prefs_->SetBoolean("testb", true); 38 prefs_->SetBoolean("testb", true);
37 prefs_->SetString("tests", "testvalue"); 39 prefs_->SetString("tests", "testvalue");
38 prefs_->WritePrefs(); 40 prefs_->WritePrefs();
39 MessageLoop::current()->RunAllPending(); 41 message_loop_.RunAllPending();
40 prefs_->SetBoolean("testb", false); // overwrite 42 prefs_->SetBoolean("testb", false); // overwrite
41 prefs_->SetString("tests", ""); // overwrite 43 prefs_->SetString("tests", ""); // overwrite
42 prefs_->ReadPrefs(); 44 prefs_->ReadPrefs();
43 EXPECT_EQ(prefs_->GetBoolean("testb", false), true); 45 EXPECT_EQ(prefs_->GetBoolean("testb", false), true);
44 EXPECT_EQ(prefs_->GetString("tests", ""), "testvalue"); 46 EXPECT_EQ(prefs_->GetString("tests", ""), "testvalue");
45 } 47 }
46 48
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698