Moved JsonPrefStore to use SequencedWorkerPool

chrome/browser/extensions/test_extension_prefs.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_TEST_EXTENSION_PREFS_H_
 #define CHROME_BROWSER_EXTENSIONS_TEST_EXTENSION_PREFS_H_
 
 #include <string>
 
 #include "base/memory/scoped_ptr.h"
+#include "base/message_loop.h"
 #include "base/scoped_temp_dir.h"
 #include "chrome/common/extensions/extension.h"
 
 class ExtensionPrefValueMap;
 class PrefService;
 
 namespace base {
 class DictionaryValue;
+class SequencedWorkerPool;
 }
 
 namespace extensions {
 class ExtensionPrefs;
 
 // This is a test class intended to make it easier to work with ExtensionPrefs
 // in tests.
 class TestExtensionPrefs {
  public:
-  TestExtensionPrefs();
+  explicit TestExtensionPrefs(base::SequencedWorkerPool* blocking_pool);

[akalin, 2012/10/18 23:52:24]

can you change to take an STR instead? (See my other comments for PrefStoreMock,
etc.)

In general, I'd like to minimize use of SWP in unit tests that aren't explicitly
testing its behavior, since it has some subtle behavior.

[zel, 2012/10/19 01:20:32]

Done.

   virtual ~TestExtensionPrefs();
 
   ExtensionPrefs* prefs() { return prefs_.get(); }
   const ExtensionPrefs& const_prefs() const {
       return *prefs_.get();
   }
   PrefService* pref_service() { return pref_service_.get(); }
   const FilePath& temp_dir() const { return temp_dir_.path(); }
 
   // This will cause the ExtensionPrefs to be deleted and recreated, based on
@@ skipping 30 matching lines @@
   // active after calling RecreateExtensionPrefs(). Defaults to false.
   void set_extensions_disabled(bool extensions_disabled);
 
  protected:
   ScopedTempDir temp_dir_;
   FilePath preferences_file_;
   FilePath extensions_dir_;
   scoped_ptr<PrefService> pref_service_;
   scoped_ptr<ExtensionPrefs> prefs_;
   scoped_ptr<ExtensionPrefValueMap> extension_pref_value_map_;
+  // A blocking pool that we can use for file operations.
+  scoped_refptr<base::SequencedWorkerPool> blocking_pool_;
 
  private:
   bool extensions_disabled_;
   DISALLOW_COPY_AND_ASSIGN(TestExtensionPrefs);
 };
 
 }  // namespace extensions
 
 #endif  // CHROME_BROWSER_EXTENSIONS_TEST_EXTENSION_PREFS_H_