Moved JsonPrefStore to use SequencedWorkerPool

chrome/browser/extensions/extension_prefs_unittest.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_PREFS_UNITTEST_H_
 #define CHROME_BROWSER_EXTENSIONS_EXTENSION_PREFS_UNITTEST_H_
 
 #include "base/message_loop.h"
 #include "chrome/browser/extensions/test_extension_prefs.h"
 #include "content/public/test/test_browser_thread.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace base {
+class SequencedWorkerPool;

[akalin, 2012/10/19 02:00:51]

not needed anymore, right?

[zel, 2012/10/19 18:45:07]

Done.

 class Value;
 }
 
 namespace extensions {
 class Extension;
 
 // Base class for extension preference-related unit tests.
 class ExtensionPrefsTest : public testing::Test {
  public:
   ExtensionPrefsTest();
   virtual ~ExtensionPrefsTest();
 
   // This function will get called once, and is the right place to do operations
   // on ExtensionPrefs that write data.
   virtual void Initialize() = 0;
 
   // This function will be called twice - once while the original ExtensionPrefs
   // object is still alive, and once after recreation. Thus, it tests that
   // things don't break after any ExtensionPrefs startup work.
   virtual void Verify() = 0;
 
   // This function is called to Register preference default values.
   virtual void RegisterPreferences();
 
   virtual void SetUp() OVERRIDE;
 
   virtual void TearDown() OVERRIDE;
 
  protected:
-  ExtensionPrefs* prefs() { return prefs_.prefs(); }
+  ExtensionPrefs* prefs() { return prefs_->prefs(); }
 
   MessageLoop message_loop_;
   content::TestBrowserThread ui_thread_;
   content::TestBrowserThread file_thread_;
 
-  TestExtensionPrefs prefs_;
+  scoped_ptr<TestExtensionPrefs> prefs_;

[akalin, 2012/10/19 02:00:51]

why did you make this a scoped_ptr?  It looks like it's not necessary anymore;
you create it only in the constructor and destroy it only in the destructor.

[zel, 2012/10/19 18:45:07]

Done.

 
  private:
   DISALLOW_COPY_AND_ASSIGN(ExtensionPrefsTest);
 };
 
 class ExtensionPrefsPrepopulatedTest : public ExtensionPrefsTest {
  public:
   ExtensionPrefsPrepopulatedTest();
   virtual ~ExtensionPrefsPrepopulatedTest();
 
@@ skipping 32 matching lines @@
 
   scoped_refptr<Extension> ext1_scoped_;
   scoped_refptr<Extension> ext2_scoped_;
   scoped_refptr<Extension> ext3_scoped_;
   scoped_refptr<Extension> ext4_scoped_;
 };
 
 }  // namespace extensions
 
 #endif  // CHROME_BROWSER_EXTENSIONS_EXTENSION_PREFS_UNITTEST_H_