Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 11027067: Add cc_unittests to android_experimental target (Closed)

Created:
8 years, 2 months ago by Nayan
Modified:
8 years, 1 month ago
CC:
chromium-reviews, cc-bugs_chromium.org, peter+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy+watch_chromium.org
Visibility:
Public.

Description

[Android] Add cc_unittests to android_experimental target This change adds cc_unittests and cc_unittests_apk targets to android_experimental targets list. Intention is to enable these targets in fyi bots first before enabling them in mail builders.

Patch Set 1 #

Patch Set 2 : Step 1 - Add compile target to android_experimental #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -1 line) Patch
M build/all_android.gyp View 1 1 chunk +8 lines, -0 lines 0 comments Download
M cc/cc_tests.gyp View 3 chunks +25 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
Nayan
While going through compositor code, I found that unittests for cc are not yet running ...
8 years, 2 months ago (2012-10-05 18:35:00 UTC) #1
Isaac (away)
Thanks for the patch! We need to wrap these tests in an APK before enabling. ...
8 years, 2 months ago (2012-10-05 19:27:35 UTC) #2
Isaac (away)
Err, sorry -- didn't look at this carefully enough. Sending to Nilesh for review.
8 years, 2 months ago (2012-10-05 19:31:20 UTC) #3
nilesh
Lets do it in steps Add compile target: 1. Add the target to android_experimental in ...
8 years, 2 months ago (2012-10-05 20:39:53 UTC) #4
Nayan
As first step, I have added cc_unittests and cc_unittests_apk targets to android_experiemental target list. Can ...
8 years, 2 months ago (2012-10-09 12:08:43 UTC) #5
Nayan
8 years, 2 months ago (2012-10-09 12:09:15 UTC) #6
nilesh
Also see: http://codereview.chromium.org/11027067/
8 years, 2 months ago (2012-10-09 17:07:08 UTC) #7
nilesh
8 years, 2 months ago (2012-10-09 17:07:21 UTC) #8
On 2012/10/09 17:07:08, nileshagrawal1 wrote:
> Also see: http://codereview.chromium.org/11027067/

Sorry this one: http://codereview.chromium.org/11077011/

Powered by Google App Engine
This is Rietveld 408576698