Add a class to replace ImageLoadingTracker with a nicer API.

chrome/browser/extensions/extension_system.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_SYSTEM_H_
 #define CHROME_BROWSER_EXTENSIONS_EXTENSION_SYSTEM_H_
 
 #include <string>
 
 #include "base/memory/ref_counted.h"
@@ skipping 12 matching lines @@
 class Profile;
 
 namespace extensions {
 // Unfortunately, for the ApiResourceManager<> template classes, we don't seem
 // to be able to forward-declare because of compilation errors on Windows.
 class AlarmManager;
 class EventRouter;
 class Extension;
 class ExtensionPrefs;
 class ExtensionSystemSharedFactory;
+class ImageLoader;
 class LazyBackgroundTaskQueue;
 class ManagementPolicy;
 class MessageService;
 class NavigationObserver;
 class RulesRegistryService;
 class ShellWindowGeometryCache;
 class StateStore;
 class UserScriptMaster;
 
 // The ExtensionSystem manages the creation and destruction of services
@@ skipping 54 matching lines @@
 
   // The MessageService is created at startup.
   virtual MessageService* message_service() = 0;
 
   // The EventRouter is created at startup.
   virtual EventRouter* event_router() = 0;
 
   // The RulesRegistryService is created at startup.
   virtual RulesRegistryService* rules_registry_service() = 0;
 
+  // Returns the ImageLoader that should be used to load extension images.
+  virtual ImageLoader* image_loader() = 0;
+
   // The SerialConnection ResourceManager is created at startup.
   virtual ApiResourceManager<SerialConnection>*
   serial_connection_manager() = 0;
 
   // The Socket ResourceManager is created at startup.
   virtual ApiResourceManager<Socket>*
   socket_manager() = 0;
 
   // The UsbDeviceResource ResourceManager is created at startup.
   virtual ApiResourceManager<UsbDeviceResource>*
@@ skipping 30 matching lines @@
 
   virtual void InitForRegularProfile(bool extensions_enabled) OVERRIDE;
   virtual void InitForOTRProfile() OVERRIDE;
 
   virtual ExtensionService* extension_service() OVERRIDE;  // shared
   virtual ManagementPolicy* management_policy() OVERRIDE;  // shared
   virtual UserScriptMaster* user_script_master() OVERRIDE;  // shared
   virtual ExtensionDevToolsManager* devtools_manager() OVERRIDE;
   virtual ExtensionProcessManager* process_manager() OVERRIDE;
   virtual AlarmManager* alarm_manager() OVERRIDE;
-  virtual StateStore* state_store() OVERRIDE;
-  virtual ShellWindowGeometryCache* shell_window_geometry_cache() OVERRIDE;
+  virtual StateStore* state_store() OVERRIDE;  // shared
+  virtual ShellWindowGeometryCache* shell_window_geometry_cache()
+      OVERRIDE;  // shared
   virtual LazyBackgroundTaskQueue* lazy_background_task_queue()
       OVERRIDE;  // shared
   virtual ExtensionInfoMap* info_map() OVERRIDE;  // shared
   virtual MessageService* message_service() OVERRIDE;  // shared
   virtual EventRouter* event_router() OVERRIDE;  // shared
   virtual RulesRegistryService* rules_registry_service()
       OVERRIDE;  // shared
+  virtual ImageLoader* image_loader() OVERRIDE;  // shared
   virtual ApiResourceManager<SerialConnection>* serial_connection_manager()
       OVERRIDE;
   virtual ApiResourceManager<Socket>* socket_manager() OVERRIDE;
   virtual ApiResourceManager<UsbDeviceResource>* usb_device_resource_manager()
       OVERRIDE;
 
   virtual void RegisterExtensionWithRequestContexts(
       const Extension* extension) OVERRIDE;
 
   virtual void UnregisterExtensionWithRequestContexts(
@@ skipping 21 matching lines @@
 
     StateStore* state_store();
     ShellWindowGeometryCache* shell_window_geometry_cache();
     ExtensionService* extension_service();
     ManagementPolicy* management_policy();
     UserScriptMaster* user_script_master();
     ExtensionInfoMap* info_map();
     LazyBackgroundTaskQueue* lazy_background_task_queue();
     MessageService* message_service();
     EventRouter* event_router();
+    ImageLoader* image_loader();
 
    private:
     Profile* profile_;
 
     // The services that are shared between normal and incognito profiles.
 
     scoped_ptr<StateStore> state_store_;
     scoped_ptr<ShellWindowGeometryCache> shell_window_geometry_cache_;
     scoped_ptr<ExtensionPrefs> extension_prefs_;
     // ExtensionService depends on the 2 above.
     scoped_ptr<ExtensionService> extension_service_;
     scoped_ptr<ManagementPolicy> management_policy_;
     scoped_refptr<UserScriptMaster> user_script_master_;
     // extension_info_map_ needs to outlive extension_process_manager_.
     scoped_refptr<ExtensionInfoMap> extension_info_map_;
     // This is a dependency of MessageService and EventRouter.
     scoped_ptr<LazyBackgroundTaskQueue> lazy_background_task_queue_;
     scoped_ptr<MessageService> message_service_;
     scoped_ptr<EventRouter> extension_event_router_;
+    scoped_ptr<ImageLoader> image_loader_;
     scoped_ptr<NavigationObserver> navigation_observer_;
   };
 
   Profile* profile_;
 
   Shared* shared_;
 
   // The services that have their own instances in incognito.
   scoped_refptr<ExtensionDevToolsManager> extension_devtools_manager_;
   // |extension_process_manager_| must be destroyed before the Profile's
   // |io_data_|. While |extension_process_manager_| still lives, we handle
   // incoming resource requests from extension processes and those require
   // access to the ResourceContext owned by |io_data_|.
   scoped_ptr<ExtensionProcessManager> extension_process_manager_;
   scoped_ptr<AlarmManager> alarm_manager_;
   scoped_ptr<ApiResourceManager<SerialConnection> > serial_connection_manager_;
   scoped_ptr<ApiResourceManager<Socket> > socket_manager_;
   scoped_ptr<ApiResourceManager<
                UsbDeviceResource> > usb_device_resource_manager_;
   scoped_ptr<RulesRegistryService> rules_registry_service_;
 
   DISALLOW_COPY_AND_ASSIGN(ExtensionSystemImpl);
 };
 
 }  // namespace extensions
 
 #endif  // CHROME_BROWSER_EXTENSIONS_EXTENSION_SYSTEM_H_