Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Unified Diff: chromeos/dbus/debug_daemon_client.cc

Issue 11026008: Adding GetFeedbackLogs call to DebugDaemon Dbus client. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Added constants. Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromeos/dbus/debug_daemon_client.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/dbus/debug_daemon_client.cc
diff --git a/chromeos/dbus/debug_daemon_client.cc b/chromeos/dbus/debug_daemon_client.cc
index 05d3b394ddce75695455ce808f9ccd1209c04f3f..1698d1c27b7b6faa3d2aa4e6639d95132d0ad718 100644
--- a/chromeos/dbus/debug_daemon_client.cc
+++ b/chromeos/dbus/debug_daemon_client.cc
@@ -249,7 +249,19 @@ class DebugDaemonClientImpl : public DebugDaemonClient {
virtual void GetAllLogs(const GetAllLogsCallback& callback)
OVERRIDE {
dbus::MethodCall method_call(debugd::kDebugdInterface,
- "GetAllLogs");
+ debugd::kGetAllLogs);
+ debugdaemon_proxy_->CallMethod(
+ &method_call,
+ dbus::ObjectProxy::TIMEOUT_USE_DEFAULT,
+ base::Bind(&DebugDaemonClientImpl::OnGetAllLogs,
+ weak_ptr_factory_.GetWeakPtr(),
+ callback));
+ }
+
+ virtual void GetFeedbackLogs(const GetAllLogsCallback& callback)
+ OVERRIDE {
+ dbus::MethodCall method_call(debugd::kDebugdInterface,
+ debugd::kGetFeedbackLogs);
debugdaemon_proxy_->CallMethod(
&method_call,
dbus::ObjectProxy::TIMEOUT_USE_DEFAULT,
@@ -508,38 +520,50 @@ class DebugDaemonClientStubImpl : public DebugDaemonClient {
const GetDebugLogsCallback& callback) OVERRIDE {
callback.Run(false);
}
+
virtual void SetDebugMode(const std::string& subsystem,
const SetDebugModeCallback& callback) OVERRIDE {
callback.Run(false);
}
+
virtual void StartSystemTracing() OVERRIDE {}
+
virtual bool RequestStopSystemTracing(const StopSystemTracingCallback&
callback) OVERRIDE {
std::string no_data;
callback.Run(base::RefCountedString::TakeString(&no_data));
return true;
}
+
virtual void GetRoutes(bool numeric, bool ipv6,
const GetRoutesCallback& callback) OVERRIDE {
std::vector<std::string> empty;
callback.Run(false, empty);
}
+
virtual void GetNetworkStatus(const GetNetworkStatusCallback& callback)
OVERRIDE {
callback.Run(false, "");
}
+
virtual void GetModemStatus(const GetModemStatusCallback& callback)
OVERRIDE {
callback.Run(false, "");
}
+
virtual void GetNetworkInterfaces(
const GetNetworkInterfacesCallback& callback) OVERRIDE {
callback.Run(false, "");
}
+
virtual void GetAllLogs(const GetAllLogsCallback& callback) OVERRIDE {
std::map<std::string, std::string> empty;
callback.Run(false, empty);
}
satorux1 2012/11/01 01:59:10 nit: put a blank line here
+ virtual void GetFeedbackLogs(const GetAllLogsCallback& callback) OVERRIDE {
+ std::map<std::string, std::string> empty;
+ callback.Run(false, empty);
+ }
virtual void TestICMP(const std::string& ip_address,
const TestICMPCallback& callback) OVERRIDE {
« no previous file with comments | « chromeos/dbus/debug_daemon_client.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698