Update PPP side of Pepper CDM API to support video decoding.

webkit/plugins/ppapi/ppapi_plugin_instance.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "webkit/plugins/ppapi/ppapi_plugin_instance.h"
 
 #include "base/bind.h"
 #include "base/debug/trace_event.h"
 #include "base/logging.h"
 #include "base/memory/linked_ptr.h"
@@ skipping 1526 matching lines @@
 
   DCHECK(!ContainsKey(pending_decryption_cbs_, request_id));
   pending_decryption_cbs_.insert(std::make_pair(request_id, decrypt_cb));
 
   plugin_decryption_interface_->Decrypt(pp_instance(),
                                         encrypted_resource,
                                         &block_info);
   return true;
 }
 
-bool PluginInstance::DecryptAndDecode(
-    const scoped_refptr<media::DecoderBuffer>& encrypted_buffer,
+bool PluginInstance::DecryptAndDecodeFrame(
+    const scoped_refptr<media::DecoderBuffer>& encrypted_frame,
     const media::Decryptor::DecryptCB& decrypt_cb) {
   if (!LoadContentDecryptorInterface())
     return false;
 
   ScopedPPResource encrypted_resource(MakeBufferResource(
       pp_instance(),
-      encrypted_buffer->GetData(),
-      encrypted_buffer->GetDataSize()));
+      encrypted_frame->GetData(),
+      encrypted_frame->GetDataSize()));
   if (!encrypted_resource.get())
     return false;
 
-  PP_EncryptedBlockInfo block_info;
+  const uint32_t request_id = next_decryption_request_id_++;
+
+  // TODO(tomfinegan): Need to get the video format information here somehow.
+  PP_EncryptedVideoFrameInfo frame_info;
+  frame_info.width = 0;
+  frame_info.height = 0;
+  frame_info.format = PP_DECRYPTEDFRAMEFORMAT_UNKNOWN;
+  frame_info.codec = PP_VIDEOCODEC_UNKNOWN;
+
+  DCHECK(encrypted_frame->GetDecryptConfig());

[ddorwin, 2012/10/01 00:48:10]

There must be a config, but the frame doesn't need to be encrypted, right? Might
be worth a comment somewhere that this function (and the PP* functions) take
unencrypted frames.

[Tom Finegan, 2012/10/02 02:42:26]

Added short notes above PPP_ methods in ppapi_plugin_instance.h, and just above
MakeEncryptedBlock.

+  if (!MakeEncryptedBlockInfo(*encrypted_frame->GetDecryptConfig(),
+                              encrypted_frame->GetTimestamp().InMicroseconds(),
+                              request_id,
+                              &frame_info.encrypted_frame_info)) {
+    return false;
+  }
+
+  DCHECK(!ContainsKey(pending_decryption_cbs_, request_id));
+  pending_decryption_cbs_.insert(std::make_pair(request_id, decrypt_cb));
 
   // TODO(tomfinegan): Store callback and ID in a map, and pass ID to decryptor.
-  plugin_decryption_interface_->DecryptAndDecode(pp_instance(),
-                                                 encrypted_resource,
-                                                 &block_info);
+  plugin_decryption_interface_->DecryptAndDecodeFrame(pp_instance(),
+                                                      encrypted_resource,
+                                                      &frame_info);
   return true;
 }
 
 bool PluginInstance::FlashIsFullscreenOrPending() {
   return fullscreen_container_ != NULL;
 }
 
 bool PluginInstance::IsFullscreenOrPending() {
   return desired_fullscreen_state_;
 }
@@ skipping 1112 matching lines @@
   screen_size_for_fullscreen_ = gfx::Size();
   WebElement element = container_->element();
   element.setAttribute(WebString::fromUTF8(kWidth), width_before_fullscreen_);
   element.setAttribute(WebString::fromUTF8(kHeight), height_before_fullscreen_);
   element.setAttribute(WebString::fromUTF8(kBorder), border_before_fullscreen_);
   element.setAttribute(WebString::fromUTF8(kStyle), style_before_fullscreen_);
 }
 
 }  // namespace ppapi
 }  // namespace webkit