Add Accessibility name for native buttons.

Add Accessibility name for native buttons.

Remove the accessible name from Checkbox since it inherits from NativeButton. Dialogs with autogenerated buttons now have MSAA name attached to it, as well as all the checkboxes.

BUG=38987
TEST=Ran it in AccExplorer

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=42401

[Mohamed Mansour, 2010-03-23 00:21:51]

One line review, thanks Chris!

[Chris Guillory, 2010-03-23 01:42:26]

Why not put this in the NativeButton constructor?

[Mohamed Mansour, 2010-03-23 01:47:55]

On 2010/03/23 01:42:26, Chris Guillory wrote:
> Why not put this in the NativeButton constructor?

How about we go deeper and add it to the button.h constructor instead?

[Mohamed Mansour, 2010-03-23 01:48:37]

On 2010/03/23 01:47:55, Mohamed Mansour wrote:
> On 2010/03/23 01:42:26, Chris Guillory wrote:
> > Why not put this in the NativeButton constructor?
> 
> How about we go deeper and add it to the button.h constructor instead?

Can we assume that every buttons's accessible name is its "label" name?

[Mohamed Mansour, 2010-03-23 01:52:51]

On 2010/03/23 01:48:37, Mohamed Mansour wrote:
> Can we assume that every buttons's accessible name is its "label" name?

Sorry for repost, actually we cannot, since we need a type that stores the name
since some buttons (on toolstrip) have no name.

Now if we use NativeButton, that means we can remove the overridden
accessibility for Checkbox and remove some unwanted code from other views? I
think we should do this. What do you think?

[Chris Guillory, 2010-03-23 02:08:40]

> Now if we use NativeButton, that means we can remove the overridden
> accessibility for Checkbox and remove some unwanted code from other views? I
> think we should do this. What do you think?

Agree. Default accessible name can be the NativeButton name.

[Mohamed Mansour, 2010-03-23 03:41:04]

Please review. I removed the accessible name from Checkbox since it inherits
everything from NativeButton. I checked with AccExlporer that the Checkbox have
MSAA name. And double checked the dialog buttons are present.

[Chris Guillory, 2010-03-23 17:08:27]

LGTM