tools/testing/dart/test_suite.dart - Issue 11018014: Change run_vm_tests to take the VM arguments before the test name so

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/testing/dart/test_suite.dart

Issue 11018014: Change run_vm_tests to take the VM arguments before the test name so (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/testing/dart/test_suite.dart

diff --git a/tools/testing/dart/test_suite.dart b/tools/testing/dart/test_suite.dart

index 458ac98fa59421f89ec188e61953e9d1d74d6bdf..795f242297c9b00c8578688c5341cd2937eec921 100644

--- a/tools/testing/dart/test_suite.dart

+++ b/tools/testing/dart/test_suite.dart

@@ -143,10 +143,8 @@ class CCTestSuite implements TestSuite {

if (expectations.contains(SKIP)) return;

- // The cc test runner takes options after the name of the test

- // to run.

- var args = [testName];

- args.addAll(TestUtils.standardOptions(configuration));

+ var args = TestUtils.standardOptions(configuration);

+ args.add(testName);

doTest(new TestCase(constructedName,

[new Command(runnerPath, args)],

« runtime/bin/run_vm_tests.cc ('K') | « runtime/bin/run_vm_tests.cc ('k') | no next file » | no next file with comments »