Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1684)

Unified Diff: ash/wm/window_animations.cc

Issue 11017079: Remove Shell::shelf()|status_area_widget()|launcher() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/wm/window_animations.cc
diff --git a/ash/wm/window_animations.cc b/ash/wm/window_animations.cc
index 66831b27469b20f4c13e2fe74575932383d149d9..e04c4b1ea9029e07ed5ce1160b29ec0ae8827ba7 100644
--- a/ash/wm/window_animations.cc
+++ b/ash/wm/window_animations.cc
@@ -397,7 +397,7 @@ void AnimateHideWindow_Workspace(aura::Window* window) {
}
gfx::Rect GetMinimizeRectForWindow(aura::Window* window) {
- gfx::Rect target_bounds = Shell::GetInstance()->launcher()->
+ gfx::Rect target_bounds = Launcher::ForWindow(window)->
sky 2012/10/17 16:25:20 This should NULL check launcher.
oshima 2012/10/17 17:49:43 There wasn't null check. Why we need now?
sky 2012/10/17 21:22:56 It's a bug. The launcher is lazily created.
GetScreenBoundsOfItemIconForWindow(window);
if (target_bounds.IsEmpty()) {
// Assume the launcher is overflowed, zoom off to the bottom right of the

Powered by Google App Engine
This is Rietveld 408576698