Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(699)

Unified Diff: ash/shell.h

Issue 11017079: Remove Shell::shelf()|status_area_widget()|launcher() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/shell.h
diff --git a/ash/shell.h b/ash/shell.h
index 2f08927ccab2034a515ff1cb8a4bf41642431dee..fa37bd870df927f7a15bfba740299f3bd4f4eacd 100644
--- a/ash/shell.h
+++ b/ash/shell.h
@@ -75,6 +75,7 @@ class SystemTray;
class UserActivityDetector;
class UserWallpaperDelegate;
class VideoDetector;
+class WebNotificationTray;
class WindowCycleController;
namespace internal {
@@ -232,6 +233,10 @@ class ASH_EXPORT Shell : internal::SystemModalContainerEventFilterDelegate{
// Called when the user logs in.
void OnLoginStateChanged(user::LoginStatus status);
+ // Called when the login status changes.
+ // TODO(oshima): Investigate if we can merge this and |OnLoginStateChanged|.
+ void UpdateAfterLoginStatusChange(user::LoginStatus status);
+
// Called when the application is exiting.
void OnAppTerminating();
@@ -311,9 +316,6 @@ class ASH_EXPORT Shell : internal::SystemModalContainerEventFilterDelegate{
return magnification_controller_.get();
}
- // TODO(oshima): Remove methods that are moved to RootWindowController.
- Launcher* launcher();
-
const ScreenAsh* screen() { return screen_.get(); }
// Force the shelf to query for it's current visibility state.
@@ -338,10 +340,8 @@ class ASH_EXPORT Shell : internal::SystemModalContainerEventFilterDelegate{
// on all displays.
void OnModalWindowRemoved(aura::Window* removed);
- // TODO(sky): don't expose this!
- internal::ShelfLayoutManager* shelf() const;
-
- internal::StatusAreaWidget* status_area_widget() const;
+ // Returns WebNotificationTray on the primary root window.
+ WebNotificationTray* GetWebNotificationTray();
sky 2012/10/17 16:25:20 I thought we were only going to have the tray on t
oshima 2012/10/17 17:49:43 All launchers will have trays (menu/battery/ime),
// Convenience accessor for members of StatusAreaWidget.
SystemTrayDelegate* tray_delegate();

Powered by Google App Engine
This is Rietveld 408576698