Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Unified Diff: ui/gfx/image/image_skia_operations.h

Issue 11017046: Use LANCZOS3 resize algorithm to generate missing image reps for extension action icons. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/gfx/image/image_skia_operations.h
diff --git a/ui/gfx/image/image_skia_operations.h b/ui/gfx/image/image_skia_operations.h
index 80326b6f2df1ef911eeae43e293c33b897deaec1..7e81b53c073b2804f70a07f5bda5d799b24eb53e 100644
--- a/ui/gfx/image/image_skia_operations.h
+++ b/ui/gfx/image/image_skia_operations.h
@@ -79,10 +79,20 @@ class UI_EXPORT ImageSkiaOperations {
const gfx::Rect& subset_bounds);
// Creates an image by resizing |source| to given |target_dip_size|.
+ // If |source| is missing the representation for a required scale factor, the
+ // representation for the scale factor will be generated by resizing one of
+ // |source|'s existing representations' bitmap to the target pixel size.
pkotwicz 2012/10/17 18:42:20 Nit: mention that we are resizing using |methd| in
tbarzic 2012/10/17 19:00:46 Done.
static ImageSkia CreateResizedImage(const ImageSkia& source,
skia::ImageOperations::ResizeMethod methd,
const Size& target_dip_size);
+ // Creates an image which inherits image representations from |source|.
+ // Image representations for the scale factors not containted in |source| are
+ // generated by resizing existing representations using |resize_method|.
+ static ImageSkia SetFallbackResizeMethod(
pkotwicz 2012/10/17 18:42:20 How about GetImageWithCustomResizeMethod() ?
tbarzic 2012/10/17 19:00:46 yeah, sounds much better (I'll use 'Create' instea
+ const ImageSkia& source,
+ skia::ImageOperations::ResizeMethod method);
+
// Creates an image with drop shadow defined in |shadows| for |source|.
static ImageSkia CreateImageWithDropShadow(const ImageSkia& source,
const ShadowValues& shadows);

Powered by Google App Engine
This is Rietveld 408576698