Added UMA metrics for ActionBox

chrome/browser/ui/toolbar/action_box_button_controller.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/toolbar/action_box_button_controller.h"
 
 #include "base/logging.h"
+#include "base/metrics/histogram.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/extensions/extension_system.h"
 #include "chrome/browser/intents/web_intents_registry_factory.h"
 #include "chrome/browser/intents/web_intents_registry.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_commands.h"
 #include "chrome/browser/ui/browser_tabstrip.h"
 #include "chrome/browser/ui/toolbar/action_box_menu_model.h"
 #include "chrome/common/chrome_notification_types.h"
 #include "chrome/common/extensions/extension.h"
 #include "chrome/common/extensions/extension_set.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/browser/notification_source.h"
+#include "content/public/browser/user_metrics.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/browser/web_intents_dispatcher.h"
 #include "grit/generated_resources.h"
 #include "webkit/glue/web_intent_data.h"
 #include "webkit/glue/webkit_glue.h"
 
 namespace {
 
 // Share intents get command IDs that are beyond the maximal valid command ID
 // (0xDFFF) so that they are not confused with actual commands that appear in
 // the menu. Extensions get a reserved block of commands after share handlers.
 // For more details see: chrome/app/chrome_command_ids.h
 const int kMaxShareItemsToShow = 20;  // TODO(skare): Show extras in submenu.
 enum ActionBoxLocalCommandIds {
   CWS_FIND_SHARE_INTENTS_COMMAND = 0xE000,
   SHARE_COMMAND_FIRST,
   SHARE_COMMAND_LAST =
       SHARE_COMMAND_FIRST + kMaxShareItemsToShow - 1,
   EXTENSION_COMMAND_FIRST
 };
 
 const char kShareIntentAction[] = "http://webintents.org/share";
 const char kShareIntentMimeType[] = "text/uri-list";
 
 }  // namespace
 
+using content::UserMetricsAction;
+
 ActionBoxButtonController::ActionBoxButtonController(Browser* browser,
                                                      Delegate* delegate)
     : browser_(browser),
       delegate_(delegate),
-      next_extension_command_id_(EXTENSION_COMMAND_FIRST) {
+      next_extension_command_id_(EXTENSION_COMMAND_FIRST),
+      should_send_uma_(true) {
   DCHECK(browser_);
   DCHECK(delegate_);
   registrar_.Add(this,
                  chrome::NOTIFICATION_EXTENSION_UNLOADED,
                  content::Source<Profile>(browser->profile()));
 }
 
 ActionBoxButtonController::~ActionBoxButtonController() {}
 
 void ActionBoxButtonController::OnButtonClicked() {
@@ skipping 29 matching lines @@
         // disambiguate. Choosing the first matches the picker behavior; see
         // TODO in WebIntentPickerController::DispatchToInstalledExtension.
         share_intent_service_ids_[command_id] = services[0].service_url;
         menu_model->AddItem(command_id, services[0].title);
       }
     }
 
     // Add link to the Web Store to find additional share intents.
     menu_model->AddItemWithStringId(CWS_FIND_SHARE_INTENTS_COMMAND,
         IDS_FIND_SHARE_INTENTS);
+
+    content::RecordAction(UserMetricsAction("ActionBox.ClickButton"));
+    if (should_send_uma_) {

[skare_, 2012/10/17 00:29:15]

logic and stat look good, perhaps call this send_uma_provider_count_ or
something. We will have stats like the previous line that are already getting
set even when "should_send_uma_" will be false.

I don't know if Chrome style allows local statics but that could allow not
making this a member.

[Wei Li, 2012/10/17 05:23:06]

Done. 

+      UMA_HISTOGRAM_ENUMERATION("ActionBox.ShareCommandCount",
+          next_share_intent_command_id - SHARE_COMMAND_FIRST,
+          SHARE_COMMAND_LAST);

[skare_, 2012/10/17 00:29:15]

I'm new to Chrome UMA but should this be kMaxShareItemsToShow?

[Wei Li, 2012/10/17 05:23:06]

Done.
Nice catch. I didn't notice the start value of the enum. According to the macro
definition, the last param should be the boundary value strictly larger than any
enum so I plus it by one.

+      should_send_uma_ = false;
+    }
   }
 
   // Add Extensions.
   next_extension_command_id_ = EXTENSION_COMMAND_FIRST;
   extension_command_ids_.clear();
   const extensions::ExtensionList& extensions =
       extension_service->toolbar_model()->action_box_menu_items();
   for (extensions::ExtensionList::const_iterator it = extensions.begin();
        it != extensions.end(); ++it) {
     menu_model->AddExtension(**it, GetCommandIdForExtension(**it));
@@ skipping 105 matching lines @@
 }
 
 void ActionBoxButtonController::NavigateToWebStoreShareIntentsList() {
   const GURL& query_url = extension_urls::GetWebstoreIntentQueryURL(
       kShareIntentAction,
       kShareIntentMimeType);
   chrome::NavigateParams params(browser_->profile(), query_url,
                                 content::PAGE_TRANSITION_LINK);
   params.disposition = NEW_FOREGROUND_TAB;
   chrome::Navigate(&params);
+
+  content::RecordAction(UserMetricsAction("ActionBox.FindShares"));
+  should_send_uma_ = true;
 }