Implement AwContentsClient and remove dependency on chrome/

android_webview/common/aw_content_client.cc

Index: android_webview/common/aw_content_client.cc
diff --git a/android_webview/common/aw_content_client.cc b/android_webview/common/aw_content_client.cc
new file mode 100644
index 0000000000000000000000000000000000000000..adddde7386a6612f18079334290d755a0504c97f
--- /dev/null
+++ b/android_webview/common/aw_content_client.cc
@@ -0,0 +1,76 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "android_webview/common/aw_content_client.h"
+
+#include "base/basictypes.h"
+#include "ui/base/l10n/l10n_util.h"
+#include "ui/base/resource/resource_bundle.h"
+#include "webkit/user_agent/user_agent_util.h"
+
+namespace android_webview {
+
+void AwContentClient::SetActiveURL(const GURL& url) {
+  // TODO(boliu): Implement. This method is used set the url that is used in
+  // crash reporting in case this process crashes.
+}
+
+void AwContentClient::SetGpuInfo(const content::GPUInfo& gpu_info) {
+  // No-op. Android WebView does not have gpu process.
+}
+

[joth, 2012/10/09 02:00:47]

on the general point - it's by design that the content-API design that callback
interface base classes like ContentClient may only provide _empty_
implementations of methods - just as a convenience. So no, we shouldn't need to
explicitly override for the "intentional no-op" cases

[boliu, 2012/10/09 18:01:47]

Removes all no-op or default behavior methods from this class (including ones we
don't think we need right now).

+void AwContentClient::AddPepperPlugins(
+    std::vector<content::PepperPluginInfo>* plugins) {
+  // No-op. Android Webview does not support plugins.
+}
+
+void AwContentClient::AddNPAPIPlugins(
+    webkit::npapi::PluginList* plugin_list) {
+  // No-op. Android Webview does not support plugins.
+}
+
+void AwContentClient::AddAdditionalSchemes(
+    std::vector<std::string>* standard_schemes,
+    std::vector<std::string>* savable_schemes) {
+  // TODO(boliu): Implement. Maybe register things like content:// and app
+  // asset files here?

[joth, 2012/10/09 02:00:47]

assets etc, get bundled under the file: scheme so nothing to do here for them.
content: is a valid possibility here though.  I'm not entirely clear on the
use-case for savable_schemes. 'standard' schemes modifies GURL::IsStandard()
behavior, e.g. so now GetOrigin() on a gurl ==
"content://com.company.app.table/foo/bar/4" would give "com.company.app.table"
as the origin. Note the surprising big-endian domain ordering! 
So I'd prefer to stay on the side of doing nothing here speculatively: leave it
until we have a specific need.

[mnaganov (inactive), 2012/10/09 08:57:20]

I agree, I don't see any clear benefit of having content: as a "standard
scheme."

[boliu, 2012/10/09 18:01:47]

No-op, so removing.

+}
+
+bool AwContentClient::HasWebUIScheme(const GURL& url) const {
+  // Android WebView does not use WebUIs.
+  return false;
+}
+
+bool AwContentClient::CanHandleWhileSwappedOut(const IPC::Message& message) {
+  // Android WebView is single process, so there is no swapped out renderer.
+  return false;

[joth, 2012/10/09 02:00:47]

for thoroughness, we make an effort to implement this correctly regardless of
current single-process-ness. So in this case I'd keep the method here but with a
comment saying 'currently none of the android_webview specific IPC messages need
to be processed for swapped out renderers.
(we could delegate this to a (static) method on AwRenderViewHostExt which
returns false.... but that's not consistent with other platforms and needless
plumbing at this point so inclined not to over engineer that at this point)

[boliu, 2012/10/09 18:01:47]

So this is only for embedder (ie aw) messages, and we definitely don't need to
handle anything yet. Removing.

+}
+
+std::string AwContentClient::GetProduct() const {
+  // Product part of user agent.
+  // TODO(boliu): Should we return a ChromeWebView/<version> or similar?

[boliu, 2012/10/08 22:43:43]

This is not breaking any tests because webview uses the override user agent all
the time? Need to double check how the override ua is generated.

[joth, 2012/10/09 02:00:47]

certainly not ChromeWebiew -  see b/6381306 for long version.

I think just remove this method  (inherit empty base version) and GetUserAgent,
but mnaganov to have final say on that.
Otherwise, we should strictly return "Version" here for
BuildUserAgentFromProduct to do the right thing.

[mnaganov (inactive), 2012/10/09 08:57:20]

In our implementation, we always supply user agent string from settings (it's in
ContentViewCore::loadUrl), so the value provided here will never be used.

So, yes, leave the default empty implementation for now.

[boliu, 2012/10/09 18:01:47]

I see Version/4.0 is hardcoded in ContentSettings::GetDefaultUserAgent. I'm
making that method call here so we have one consistent place for managing
*default* user agent.

[mnaganov (inactive), 2012/10/10 08:51:45]

Looks fine, thanks!

+  return std::string();
+}
+
+std::string AwContentClient::GetUserAgent() const {
+  return webkit_glue::BuildUserAgentFromProduct(GetProduct());
+}
+
+string16 AwContentClient::GetLocalizedString(int message_id) const {
+  // TODO(boliu): Used only by WebKit, so only bundle those resources for
+  // Android WebView.
+  return l10n_util::GetStringUTF16(message_id);
+}
+
+base::StringPiece AwContentClient::GetDataResource(
+    int resource_id,
+    ui::ScaleFactor scale_factor) const {
+  // TODO(boliu): Used only by WebKit, so only bundle those resources for
+  // Android WebView.
+  return ResourceBundle::GetSharedInstance().GetRawDataResource(
+      resource_id, scale_factor);
+}
+
+}  // namespace android_webview
+