Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: build/java_apk.gypi

Issue 11017016: Add support for building apk in release (Closed) Base URL: http://git.chromium.org/chromium/src.git@apk_combine
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/ant/chromium-apk.xml ('k') | chrome/android/testshell/java/AndroidManifest.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/java_apk.gypi
diff --git a/build/java_apk.gypi b/build/java_apk.gypi
index 4aa6ea8da635644a573400a5362ddf0a6470ab41..e1ebeb69fa64c98a0c7aff455268dfb141720ac6 100644
--- a/build/java_apk.gypi
+++ b/build/java_apk.gypi
@@ -77,6 +77,8 @@
'>@(additional_input_paths)',
],
'outputs': [
+ # TODO(cjhopman): Apks are built with a -debug suffix even when they are
Yaron 2012/10/08 21:58:36 We should really fix this sooner than later.
+ # built in release. This should be fixed.
'<(PRODUCT_DIR)/apks/<(apk_name)-debug.apk',
],
'action': [
@@ -102,7 +104,9 @@
'-Dbasedir=<(java_in_dir)',
'-buildfile',
- '<(DEPTH)/build/android/ant/chromium-apk.xml'
+ '<(DEPTH)/build/android/ant/chromium-apk.xml',
+
nilesh 2012/10/08 21:56:13 extra line?
+ '<(CONFIGURATION_NAME)',
Yaron 2012/10/08 21:58:36 Can you add a comment that this is specifying the
cjhopman 2012/10/09 18:18:18 Done.
]
},
],
« no previous file with comments | « build/android/ant/chromium-apk.xml ('k') | chrome/android/testshell/java/AndroidManifest.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698