Don't show downloads from web intents picker in shelf

chrome/browser/download/download_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <sstream>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/file_path.h"
 #include "base/file_util.h"
@@ skipping 185 matching lines @@
     return false;
   }
 
   DISALLOW_COPY_AND_ASSIGN(TestRenderViewContextMenu);
 };
 
 bool WasAutoOpened(DownloadItem* item) {
   return item->GetAutoOpened();
 }
 
+// Called when a download starts. Marks the download as hidden.
+void SetHiddenDownloadCallback(scoped_refptr<DownloadManager> download_manager,
+                               content::DownloadId id,
+                               net::Error error) {
+  DownloadItem* item = download_manager->GetDownload(id.local());
+  item->SetShouldShowInShelf(item, false);

[Randy Smith (Not in Mondays), 2012/10/09 19:36:06]

How does this work?  Or is it left over from a previous patchset?  (This method
doesn't exist on the DownloadItem in my checkout, and you're not doing any
changes in content.)

[sail, 2012/10/09 19:46:13]

Done.
argh, merge conflict. Fixed.

+}
+
 }  // namespace
 
 // While an object of this class exists, it will mock out download
 // opening for all downloads created on the specified download manager.
 class MockDownloadOpeningObserver : public DownloadManager::Observer {
  public:
   explicit MockDownloadOpeningObserver(DownloadManager* manager)
       : download_manager_(manager) {
     download_manager_->AddObserver(this);
   }
@@ skipping 2021 matching lines @@
   GetDownloads(browser(), &download_items);
   ASSERT_EQ(1u, download_items.size());
   ASSERT_EQ(test_server()->GetURL("echoheader?Referer"),
             download_items[0]->GetOriginalUrl());
 
   // Check that the file contains the expected referrer.
   FilePath file(download_items[0]->GetFullPath());
   std::string expected_contents = test_server()->GetURL("").spec();
   ASSERT_TRUE(VerifyFile(file, expected_contents, expected_contents.length()));
 }
+
+IN_PROC_BROWSER_TEST_F(DownloadTest, HiddenDownload) {
+  FilePath file(FILE_PATH_LITERAL("download-test1.lib"));
+  GURL url(URLRequestMockHTTPJob::GetMockUrl(file));
+
+  scoped_refptr<DownloadManager> download_manager =
+      DownloadManagerForBrowser(browser());
+  scoped_ptr<content::DownloadTestObserver> observer(
+      new content::DownloadTestObserverTerminal(
+          download_manager,
+          1,
+          content::DownloadTestObserver::ON_DANGEROUS_DOWNLOAD_FAIL));
+  content::DownloadSaveInfo save_info;
+  save_info.prompt_for_save_location = false;
+
+  // Download and set IsHiddenDownload to true.
+  WebContents* web_contents = chrome::GetActiveWebContents(browser());
+  scoped_ptr<DownloadUrlParameters> params(
+      DownloadUrlParameters::FromWebContents(web_contents, url, save_info));
+  params->set_callback(
+      base::Bind(&SetHiddenDownloadCallback, download_manager));
+  download_manager->DownloadUrl(params.Pass());
+  observer->WaitForFinished();
+
+  // Verify that download shelf is not shown.
+  EXPECT_FALSE(browser()->window()->IsDownloadShelfVisible());
+}