Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3088)

Unified Diff: chrome/browser/plugins/plugin_metadata.h

Issue 11016005: Using MIME types in addition to plugin name to differentiate between plugins. (Closed) Base URL: http://git.chromium.org/chromium/src.git@5_plugins_resource_service
Patch Set: infobarED Lightspark Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/plugins/plugin_metadata.h
diff --git a/chrome/browser/plugins/plugin_metadata.h b/chrome/browser/plugins/plugin_metadata.h
index b8ca5e0d1976857cd99ca2d81f7ef24c8cfbb532..695141d4ca6ec2f9360317ac7eacd414b6cc20fc 100644
--- a/chrome/browser/plugins/plugin_metadata.h
+++ b/chrome/browser/plugins/plugin_metadata.h
@@ -40,7 +40,8 @@ class PluginMetadata {
bool url_for_display,
const GURL& plugin_url,
const GURL& help_url,
- const string16& group_name_matcher);
+ const string16& group_name_matcher,
+ const std::string& language);
~PluginMetadata();
// Unique identifier for the plug-in.
@@ -59,11 +60,18 @@ class PluginMetadata {
// URL to open when the user clicks on the "Problems installing?" link.
const GURL& help_url() const { return help_url_; }
+ const std::string& language() const { return language_; }
+
+ bool HasMimeType(const std::string& mime_type) const;
+ void AddMimeType(const std::string& mime_type);
+ void AddMatchingMimeType(const std::string& mime_type);
+
// Adds information about a plug-in version.
void AddVersion(const Version& version, SecurityStatus status);
// Checks if the plug-in matches the group matcher.
- bool MatchesPlugin(const webkit::WebPluginInfo& plugin);
+ bool MatchesPlugin(const webkit::WebPluginInfo& plugin,
+ string16* matching_name);
// If |status_str| describes a valid security status, writes it to |status|
// and returns true, else returns false and leaves |status| unchanged.
@@ -87,7 +95,10 @@ class PluginMetadata {
bool url_for_display_;
GURL plugin_url_;
GURL help_url_;
+ std::string language_;
std::map<Version, SecurityStatus, VersionComparator> versions_;
+ std::vector<std::string> all_mime_types_;
+ std::vector<std::string> matching_mime_types_;
DISALLOW_COPY_AND_ASSIGN(PluginMetadata);
};

Powered by Google App Engine
This is Rietveld 408576698