src/trusted/service_runtime/arch/mips/sel_ldr_mips.h - Issue 11016003: [MIPS] Use break instruction as NACL_HALT for MIPS.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: src/trusted/service_runtime/arch/mips/sel_ldr_mips.h

Issue 11016003: [MIPS] Use break instruction as NACL_HALT for MIPS. (Closed) Base URL: http://src.chromium.org/native_client/trunk/src/native_client/

Patch Set: Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « src/trusted/service_runtime/arch/mips/nacl_text_pad_test.S ('k') | src/trusted/service_runtime/arch/mips/tramp_mips.S » ('j') | no next file with comments »

OLD	NEW
1 /*	1 /*

2 * Copyright 2012 The Native Client Authors. All rights reserved.	2 * Copyright 2012 The Native Client Authors. All rights reserved.

3 * Use of this source code is governed by a BSD-style license that can	3 * Use of this source code is governed by a BSD-style license that can

4 * be found in the LICENSE file.	4 * be found in the LICENSE file.

5 */	5 */

6	6

7 #ifndef SERVICE_RUNTIME_ARCH_MIPS_SEL_LDR_H__	7 #ifndef SERVICE_RUNTIME_ARCH_MIPS_SEL_LDR_H__

8 #define SERVICE_RUNTIME_ARCH_MIPS_SEL_LDR_H__ 1	8 #define SERVICE_RUNTIME_ARCH_MIPS_SEL_LDR_H__ 1

9	9

	10 #if !defined(__ASSEMBLER__)
	Mark Seaborn 2012/10/01 22:48:23 Nit: conditional #includes don't normally have emp Nit: conditional #includes don't normally have empty lines around them, so: #if !defined(__ASSEMBLER__) # include "native_client/src/include/portability.h" #endif petarj 2012/10/02 15:25:34 Done. Show quoted text On 2012/10/01 22:48:23, Mark Seaborn wrote: > Nit: conditional #includes don't normally have empty lines around them, so: > > #if !defined(__ASSEMBLER__) > # include "native_client/src/include/portability.h" > #endif Done.
	11

10 #include "native_client/src/include/portability.h"	12 #include "native_client/src/include/portability.h"

	13

	14 #endif

	15

11 #include "native_client/src/trusted/service_runtime/nacl_config.h"	16 #include "native_client/src/trusted/service_runtime/nacl_config.h"

12	17

13 #define NACL_MAX_ADDR_BITS 30	18 #define NACL_MAX_ADDR_BITS 30

14	19

15 #define NACL_ADDRSPACE_LOWER_GUARD_SIZE 0	20 #define NACL_ADDRSPACE_LOWER_GUARD_SIZE 0

16 #define NACL_ADDRSPACE_UPPER_GUARD_SIZE 0x2000	21 #define NACL_ADDRSPACE_UPPER_GUARD_SIZE 0x2000

17	22

18 /* Must be synced with irt_compatible_rodata_addr in SConstruct */	23 /* Must be synced with irt_compatible_rodata_addr in SConstruct */

19 #define NACL_DATA_SEGMENT_START 0x10000000	24 #define NACL_DATA_SEGMENT_START 0x10000000

20	25

21 #define NACL_THREAD_MAX 8192	26 #define NACL_THREAD_MAX 8192

22	27

23 #define NACL_NOOP_OPCODE 0x00000000 /* nop */	28 #define NACL_NOOP_OPCODE 0x00000000 /* nop */

24 #define NACL_HALT_OPCODE 0x00000008 /* jr $0 */	29 #define NACL_HALT_OPCODE 0x0000000D /* break */

25 #define NACL_HALT_LEN 4 /* length of halt instruction */	30 #define NACL_HALT_LEN 4 /* length of halt instruction */

26 #define NACL_HALT_WORD NACL_HALT_OPCODE	31 #define NACL_HALT_WORD NACL_HALT_OPCODE

27	32

28 #endif /* SERVICE_RUNTIME_ARCH_MIPS_SEL_LDR_H__ */	33 #endif /* SERVICE_RUNTIME_ARCH_MIPS_SEL_LDR_H__ */

OLD	NEW