Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(962)

Unified Diff: pkg/dartdoc/lib/mirrors_util.dart

Issue 11014022: Make Mirror.simpleName unique. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/dartdoc/lib/mirrors_util.dart
diff --git a/pkg/dartdoc/lib/mirrors_util.dart b/pkg/dartdoc/lib/mirrors_util.dart
index 150df5f63628d36f6119dbc3e000bd7c170e53dd..fc2cf8c329881f96f5998f4738a8212009bd75f8 100644
--- a/pkg/dartdoc/lib/mirrors_util.dart
+++ b/pkg/dartdoc/lib/mirrors_util.dart
@@ -30,7 +30,7 @@ Iterable<InterfaceMirror> computeSubdeclarations(InterfaceMirror type) {
}
}
}
- final superInterfaces = otherType.interfaces.getValues();
+ final superInterfaces = otherType.interfaces;
for (InterfaceMirror superInterface in superInterfaces) {
superInterface = superInterface.declaration;
if (type.library === superInterface.library) {
@@ -44,34 +44,6 @@ Iterable<InterfaceMirror> computeSubdeclarations(InterfaceMirror type) {
return subtypes;
}
-/**
- * Finds the mirror in [map] by the simple name [name]. If [constructorName] or
- * [operatorName] is provided, a constructor/operator method by that name is
- * returned.
- */
-Mirror findMirror(Map<Object,Mirror> map, String name,
- [String constructorName, String operatorName]) {
- var foundMirror = null;
- map.forEach((_, Mirror mirror) {
- if (mirror.simpleName == name) {
- if (constructorName !== null) {
- if (mirror is MethodMirror &&
- constructorName == mirror.constructorName) {
- foundMirror = mirror;
- }
- } else if (operatorName !== null) {
- if (mirror is MethodMirror &&
- operatorName == mirror.operatorName) {
- foundMirror = mirror;
- }
- } else {
- foundMirror = mirror;
- }
- }
- });
- return foundMirror;
-}
-
LibraryMirror findLibrary(MemberMirror member) {
ObjectMirror owner = member.surroundingDeclaration;
if (owner is LibraryMirror) {

Powered by Google App Engine
This is Rietveld 408576698