NTP5: Starting implementation of a native menu for showing other device sessions.

chrome/browser/ui/views/other_device_menu_views.cc

Index: chrome/browser/ui/views/other_device_menu_views.cc
diff --git a/chrome/browser/ui/views/other_device_menu_views.cc b/chrome/browser/ui/views/other_device_menu_views.cc
new file mode 100644
index 0000000000000000000000000000000000000000..31ba2f536750914249f1c8e110f090f4e6aba0fd
--- /dev/null
+++ b/chrome/browser/ui/views/other_device_menu_views.cc
@@ -0,0 +1,40 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/ui/views/other_device_menu_views.h"
+
+#include "ui/base/models/simple_menu_model.h"
+#include "ui/views/controls/menu/menu_model_adapter.h"
+#include "ui/views/controls/menu/menu_runner.h"
+#include "ui/views/widget/widget.h"
+
+OtherDeviceMenuViews::OtherDeviceMenuViews(ui::SimpleMenuModel* menu_model)
+    : menu_model_(menu_model) {
+}
+
+OtherDeviceMenuViews::~OtherDeviceMenuViews() {
+}
+
+void OtherDeviceMenuViews::ShowMenu(gfx::NativeWindow window,
+                                   const gfx::Point& location) {

[tfarina, 2012/10/29 01:37:43]

nit: indentation is off here!

[jeremycho, 2012/10/29 19:55:28]

Done.

+  views::Widget* widget = views::Widget::GetWidgetForNativeWindow(window);
+  if (!widget)
+    return;
+
+  views::MenuModelAdapter menu_model_adapter(menu_model_);
+  menu_runner_.reset(new views::MenuRunner(menu_model_adapter.CreateMenu()));
+
+  if (menu_runner_->RunMenuAt(widget, NULL, gfx::Rect(location, gfx::Size()),
+                              views::MenuItemView::TOPLEFT, 0) ==
+      views::MenuRunner::MENU_DELETED) {
+    return;
+  }
+}
+
+// OtherDeviceMenuController ---------------------------------------------------

[tfarina, 2012/10/29 01:37:43]

nit: s/OtherDeviceMenuController/OtherDeviceMenu

To be honest, I wouldn't have this useless comment at all, and I'd put this at
the top of this file right after the includes, not a big deal though.

[jeremycho, 2012/10/29 19:55:28]

Done.

[jeremycho, 2012/10/29 19:55:28]

Done.

+
+// static
+OtherDeviceMenu* OtherDeviceMenu::Create(ui::SimpleMenuModel* menu_model) {
+  return new OtherDeviceMenuViews(menu_model);
+}