NTP5: Starting implementation of a native menu for showing other device sessions.

chrome/browser/ui/views/other_device_menu_views.h

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_UI_VIEWS_OTHER_DEVICE_MENU_VIEWS_H_
+#define CHROME_BROWSER_UI_VIEWS_OTHER_DEVICE_MENU_VIEWS_H_
+
+#include "base/memory/scoped_ptr.h"

[tfarina, 2012/10/29 01:37:43]

include basictypes for DISALLOW_ and compiler_specific for OVERRIDE!

+#include "chrome/browser/ui/search/other_device_menu_controller.h"
+
+namespace gfx{

[tfarina, 2012/10/29 01:37:43]

nit: one whitespace between gfx and {

[jeremycho, 2012/10/29 19:55:28]

Done.

+class Point;
+}
+
+namespace ui {
+class SimpleMenuModel;
+}
+
+namespace views {
+class MenuRunner;
+}
+
+class OtherDeviceMenuViews : public OtherDeviceMenu {
+ public:
+  explicit OtherDeviceMenuViews(ui::SimpleMenuModel* menu_model);
+  virtual ~OtherDeviceMenuViews();
+
+  virtual void ShowMenu(
+      gfx::NativeWindow window, const gfx::Point& location) OVERRIDE;

[tfarina, 2012/10/29 01:37:43]

nit: one arg per line!

[jeremycho, 2012/10/29 19:55:28]

Done.

+
+ private:
+  ui::SimpleMenuModel* menu_model_;  // Owned by the controller.

[tfarina, 2012/10/29 01:37:43]

which controller? better to write the class name.

[jeremycho, 2012/10/29 19:55:28]

Done.

+  scoped_ptr<views::MenuRunner> menu_runner_;
+
+  DISALLOW_COPY_AND_ASSIGN(OtherDeviceMenuViews);
+};
+
+#endif  // CHROME_BROWSER_UI_VIEWS_OTHER_DEVICE_MENU_VIEWS_H_