Issue 1100004: Adding another special directory to check_deps script

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1100004: Adding another special directory to check_deps script (Closed)

Created:
10 years, 9 months ago by Raja Aluri

Modified:
9 years, 7 months ago

Reviewers:
davidjames, djmm

CC:
chromium-os-reviews_chromium.org

Visibility:
Public.

Description

Adding another special directory to check_deps script

Patch Set 1 #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	src/scripts/check_deps	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

davidjames

10 years, 9 months ago (2010-03-19 17:38:15 UTC) #2

LGTM, per offline discussion with aluri.

djmm, this script is for verifying that all dependencies for the executables we
built are included in the image we built. Normally, dynamically built libraries
will include a reference to the appropriate directory inside the library, but
aluri is working on a library that does not have this reference setup
appropriately and instead depends on the calling process to setup the reference.
Since this library is built by an external party and we don't have control over
it, we're adding an exception for just this library.

Expand Messages | Collapse Messages