Move validator_x86_XX.rl out of unreviewed.

src/trusted/validator_ragel/unreviewed/validator.h

 /*
  * Copyright (c) 2012 The Native Client Authors. All rights reserved.
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #ifndef NATIVE_CLIENT_SRC_TRUSTED_VALIDATOR_RAGEL_VALIDATOR_H_
 #define NATIVE_CLIENT_SRC_TRUSTED_VALIDATOR_RAGEL_VALIDATOR_H_
 
-#include "native_client/src/trusted/validator_ragel/unreviewed/decoder.h"
+#include "native_client/src/trusted/validator_ragel/decoder.h"
 
 EXTERN_C_BEGIN
 
 enum validation_callback_info {

[Brad Chen, 2012/10/05 16:47:21]

Looks like the style observations from other files haven't been applied here
yet. CamelCase for enum type names?

[khim, 2012/10/15 16:38:57]

http://dev.chromium.org/developers/coding-style
Though the Google C++ Style Guide now says to use kConstantNaming for enums,
Chromium was written using MACRO_STYLE naming.  Continue to use this style for
consistency.

[Brad Chen, 2012/10/16 00:16:55]

NaCl source uses CamelCase; please be consistent with NaCl source.

On 2012/10/15 16:38:57, khim wrote:

[Vlad Shcherbina, 2012/10/19 12:55:52]

Chromium code search results for query "enum file:native_client/src/trusted"
give an impression that CamelCase for enumeration constants is only used in old
x86 validator. C++-style-guide-recommended kConstantName occurs slighly more
often, and CONSTANT_NAME style is prevaling.

So consistency argument can possibly be in favor of CONSTANT_NAME or
kConstantName, I don't know, but it's certainly against CamelCase.

   /* Anyfield info mask: you can use to parse information about anyfields.  */
   ANYFIELD_INFO_MASK            = 0x000000ff,
   /* Immediate sizes (immediates always come at the end of instruction).  */
   IMMEDIATES_SIZE_MASK          = 0x0000000f,
   IMMEDIATE_8BIT                = 0x00000001,
   IMMEDIATE_16BIT               = 0x00000002,
   IMMEDIATE_32BIT               = 0x00000004,
   IMMEDIATE_64BIT               = 0x00000008,
   /* Second 8bit immediate is only used in "extrq/insertq" instructions.  */
   SECOND_IMMEDIATE_8BIT         = 0x00000011,
@@ skipping 75 matching lines @@
  *   instruction_start = instruction_end = jump target
  *
  * Minimal user_callback looks like this:
  *   ...
  *   if (validation_info & (VALIDATION_ERRORS_MASK | BAD_JUMP_TARGET))
  *     return FALSE;
  *   else
  *     return TRUE;
  *   ...
  */
-typedef Bool (*validation_callback_func) (const uint8_t *instruction_start,
-                                          const uint8_t *instruction_end,
-                                          uint32_t validation_info,
-                                          void *callback_data);
+typedef Bool (*ValidationCallbackFunc) (const uint8_t *instruction_start,
+                                        const uint8_t *instruction_end,
+                                        uint32_t validation_info,
+                                        void *callback_data);
 
 /*
  * Returns whether given piece of code is valid.
  * It is assumed that size % kBundleSize = 0.
  * For every error/warning, user_callback is called.
  * Alternatively, if CALL_USER_CALLBACK_ON_EACH_INSTRUCTION flag in options is
  * set, user_callback is called for every instruction.
  * If PROCESS_CHUNK_AS_A_CONTIGUOUS_STREAM flag in options is set,
  * instructions crossing bundle boundaries are not considered erroneous.
  *
  * Actually validation result is computed as conjunction of values returned
  * by all invocations of user_callback, so custom validation logic can be
  * placed there.
  */
 Bool ValidateChunkAMD64(const uint8_t *data, size_t size,
                         enum validation_options options,
                         const NaClCPUFeaturesX86 *cpu_features,
-                        validation_callback_func user_callback,
+                        ValidationCallbackFunc user_callback,
                         void *callback_data);
 
 /*
  * See ValidateChunkAMD64
  */
 Bool ValidateChunkIA32(const uint8_t *data, size_t size,
                        enum validation_options options,
                        const NaClCPUFeaturesX86 *cpu_features,
-                       validation_callback_func user_callback,
+                       ValidationCallbackFunc user_callback,
                        void *callback_data);
 
 EXTERN_C_END
 
 #endif  /* NATIVE_CLIENT_SRC_TRUSTED_VALIDATOR_RAGEL_VALIDATOR_H_ */