Move validator_x86_XX.rl out of unreviewed.

src/trusted/validator_ragel/unreviewed/parse_instruction.rl

 /*
  * Copyright (c) 2012 The Native Client Authors. All rights reserved.
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */

[Brad Chen, 2012/10/05 16:47:21]

What is this file for? It's particularly important to know if this file is or is
not used to build the production validator. At this point I think it probably
makes sense for every file to have a brief comment similar to what you added for
validator_x86_32.rl

[khim, 2012/10/15 16:38:57]

Done.

 
 %%{
   machine prefix_actions;
 
   action branch_not_taken {
     SET_BRANCH_NOT_TAKEN(TRUE);
   }
   action branch_taken {
     SET_BRANCH_TAKEN(TRUE);
   }
@@ skipping 151 matching lines @@
 %%{
   machine operand_actions_common;
 
   action operands_count_is_0 { SET_OPERANDS_COUNT(0); }
   action operands_count_is_1 { SET_OPERANDS_COUNT(1); }
   action operands_count_is_2 { SET_OPERANDS_COUNT(2); }
   action operands_count_is_3 { SET_OPERANDS_COUNT(3); }
   action operands_count_is_4 { SET_OPERANDS_COUNT(4); }
   action operands_count_is_5 { SET_OPERANDS_COUNT(5); }
 
-  action operand0_16bit      { SET_OPERAND_TYPE(0, OPERAND_SIZE_16_BIT); }
-  action operand0_8bit       { SET_OPERAND_TYPE(0, OPERAND_SIZE_8_BIT); }
-  action operand0_32bit      { SET_OPERAND_TYPE(0, OPERAND_SIZE_32_BIT); }
-  action operand0_64bit      { SET_OPERAND_TYPE(0, OPERAND_SIZE_64_BIT); }
-  action operand0_128bit     { SET_OPERAND_TYPE(0, OPERAND_SIZE_128_BIT); }
-  action operand0_256bit     { SET_OPERAND_TYPE(0, OPERAND_SIZE_256_BIT); }
-  action operand0_creg       { SET_OPERAND_TYPE(0, OPERAND_CONTROL_REGISTER); }
-  action operand0_dreg       { SET_OPERAND_TYPE(0, OPERAND_DEBUG_REGISTER); }
-  action operand0_farptr     { SET_OPERAND_TYPE(0, OPERAND_FAR_PTR); }
-  action operand0_float32bit { SET_OPERAND_TYPE(0, OPERAND_FLOAT_SIZE_32_BIT); }
-  action operand0_float64bit { SET_OPERAND_TYPE(0, OPERAND_FLOAT_SIZE_64_BIT); }
-  action operand0_float80bit { SET_OPERAND_TYPE(0, OPERAND_FLOAT_SIZE_80_BIT); }
-  action operand0_mmx        { SET_OPERAND_TYPE(0, OPERAND_MMX); }
-  action operand0_segreg     { SET_OPERAND_TYPE(0, OPERAND_SEGMENT_REGISTER); }
-  action operand0_selector   { SET_OPERAND_TYPE(0, OPERAND_SELECTOR); }
-  action operand0_x87        { SET_OPERAND_TYPE(0, OPERAND_ST); }
-  action operand0_x87_16bit  { SET_OPERAND_TYPE(0, OPERAND_X87_SIZE_16_BIT); }
-  action operand0_x87_32bit  { SET_OPERAND_TYPE(0, OPERAND_X87_SIZE_32_BIT); }
-  action operand0_x87_64bit  { SET_OPERAND_TYPE(0, OPERAND_X87_SIZE_64_BIT); }
-  action operand0_x87_bcd    { SET_OPERAND_TYPE(0, OPERAND_X87_BCD); }
-  action operand0_x87_env    { SET_OPERAND_TYPE(0, OPERAND_X87_ENV); }
+  action operand0_16bit      { SET_OPERAND_TYPE(0, OPERAND_TYPE_16_BIT); }
+  action operand0_8bit       { SET_OPERAND_TYPE(0, OPERAND_TYPE_8_BIT); }
+  action operand0_32bit      { SET_OPERAND_TYPE(0, OPERAND_TYPE_32_BIT); }
+  action operand0_64bit      { SET_OPERAND_TYPE(0, OPERAND_TYPE_64_BIT); }
+  action operand0_128bit     { SET_OPERAND_TYPE(0, OPERAND_TYPE_128_BIT); }
+  action operand0_256bit     { SET_OPERAND_TYPE(0, OPERAND_TYPE_256_BIT); }
+  action operand0_creg   { SET_OPERAND_TYPE(0, OPERAND_TYPE_CONTROL_REGISTER); }
+  action operand0_dreg     { SET_OPERAND_TYPE(0, OPERAND_TYPE_DEBUG_REGISTER); }
+  action operand0_farptr     { SET_OPERAND_TYPE(0, OPERAND_TYPE_FAR_PTR); }
+  action operand0_float32bit { SET_OPERAND_TYPE(0, OPERAND_TYPE_FLOAT_32_BIT); }
+  action operand0_float64bit { SET_OPERAND_TYPE(0, OPERAND_TYPE_FLOAT_64_BIT); }
+  action operand0_float80bit { SET_OPERAND_TYPE(0, OPERAND_TYPE_FLOAT_80_BIT); }
+  action operand0_mmx        { SET_OPERAND_TYPE(0, OPERAND_TYPE_MMX); }
+  action operand0_segreg { SET_OPERAND_TYPE(0, OPERAND_TYPE_SEGMENT_REGISTER); }
+  action operand0_selector   { SET_OPERAND_TYPE(0, OPERAND_TYPE_SELECTOR); }
+  action operand0_x87        { SET_OPERAND_TYPE(0, OPERAND_TYPE_ST); }
+  action operand0_x87_16bit  { SET_OPERAND_TYPE(0, OPERAND_TYPE_X87_16_BIT); }
+  action operand0_x87_32bit  { SET_OPERAND_TYPE(0, OPERAND_TYPE_X87_32_BIT); }
+  action operand0_x87_64bit  { SET_OPERAND_TYPE(0, OPERAND_TYPE_X87_64_BIT); }
+  action operand0_x87_bcd    { SET_OPERAND_TYPE(0, OPERAND_TYPE_X87_BCD); }
+  action operand0_x87_env    { SET_OPERAND_TYPE(0, OPERAND_TYPE_X87_ENV); }
   action operand0_x87_mmx_xmm_state {
-    SET_OPERAND_TYPE(0, OPERAND_X87_MMX_MM_STATE);
+    SET_OPERAND_TYPE(0, OPERAND_TYPE_X87_MMX_XMM_STATE);
   }
-  action operand0_x87_state  { SET_OPERAND_TYPE(0, OPERAND_X87_STATE); }
-  action operand0_xmm        { SET_OPERAND_TYPE(0, OPERAND_XMM); }
-  action operand0_ymm        { SET_OPERAND_TYPE(0, OPERAND_YMM); }
+  action operand0_x87_state  { SET_OPERAND_TYPE(0, OPERAND_TYPE_X87_STATE); }
+  action operand0_xmm        { SET_OPERAND_TYPE(0, OPERAND_TYPE_XMM); }
+  action operand0_ymm        { SET_OPERAND_TYPE(0, OPERAND_TYPE_YMM); }
 
-  action operand1_8bit       { SET_OPERAND_TYPE(1, OPERAND_SIZE_8_BIT); }
-  action operand1_16bit      { SET_OPERAND_TYPE(1, OPERAND_SIZE_16_BIT); }
-  action operand1_32bit      { SET_OPERAND_TYPE(1, OPERAND_SIZE_32_BIT); }
-  action operand1_64bit      { SET_OPERAND_TYPE(1, OPERAND_SIZE_64_BIT); }
-  action operand1_128bit     { SET_OPERAND_TYPE(1, OPERAND_SIZE_128_BIT); }
-  action operand1_256bit     { SET_OPERAND_TYPE(1, OPERAND_SIZE_256_BIT); }
-  action operand1_creg       { SET_OPERAND_TYPE(1, OPERAND_CONTROL_REGISTER); }
-  action operand1_dreg       { SET_OPERAND_TYPE(1, OPERAND_DEBUG_REGISTER); }
-  action operand1_farptr     { SET_OPERAND_TYPE(1, OPERAND_FAR_PTR); }
-  action operand1_float32bit { SET_OPERAND_TYPE(1, OPERAND_FLOAT_SIZE_32_BIT); }
-  action operand1_float64bit { SET_OPERAND_TYPE(1, OPERAND_FLOAT_SIZE_64_BIT); }
-  action operand1_mmx        { SET_OPERAND_TYPE(1, OPERAND_MMX); }
-  action operand1_segreg     { SET_OPERAND_TYPE(1, OPERAND_SEGMENT_REGISTER); }
-  action operand1_x87        { SET_OPERAND_TYPE(1, OPERAND_ST); }
-  action operand1_xmm        { SET_OPERAND_TYPE(1, OPERAND_XMM); }
-  action operand1_ymm        { SET_OPERAND_TYPE(1, OPERAND_YMM); }
+  action operand1_8bit       { SET_OPERAND_TYPE(1, OPERAND_TYPE_8_BIT); }
+  action operand1_16bit      { SET_OPERAND_TYPE(1, OPERAND_TYPE_16_BIT); }
+  action operand1_32bit      { SET_OPERAND_TYPE(1, OPERAND_TYPE_32_BIT); }
+  action operand1_64bit      { SET_OPERAND_TYPE(1, OPERAND_TYPE_64_BIT); }
+  action operand1_128bit     { SET_OPERAND_TYPE(1, OPERAND_TYPE_128_BIT); }
+  action operand1_256bit     { SET_OPERAND_TYPE(1, OPERAND_TYPE_256_BIT); }
+  action operand1_creg   { SET_OPERAND_TYPE(1, OPERAND_TYPE_CONTROL_REGISTER); }
+  action operand1_dreg     { SET_OPERAND_TYPE(1, OPERAND_TYPE_DEBUG_REGISTER); }
+  action operand1_farptr     { SET_OPERAND_TYPE(1, OPERAND_TYPE_FAR_PTR); }
+  action operand1_float32bit { SET_OPERAND_TYPE(1, OPERAND_TYPE_FLOAT_32_BIT); }
+  action operand1_float64bit { SET_OPERAND_TYPE(1, OPERAND_TYPE_FLOAT_64_BIT); }
+  action operand1_mmx        { SET_OPERAND_TYPE(1, OPERAND_TYPE_MMX); }
+  action operand1_segreg { SET_OPERAND_TYPE(1, OPERAND_TYPE_SEGMENT_REGISTER); }
+  action operand1_x87        { SET_OPERAND_TYPE(1, OPERAND_TYPE_ST); }
+  action operand1_xmm        { SET_OPERAND_TYPE(1, OPERAND_TYPE_XMM); }
+  action operand1_ymm        { SET_OPERAND_TYPE(1, OPERAND_TYPE_YMM); }
 
-  action operand2_8bit       { SET_OPERAND_TYPE(2, OPERAND_SIZE_8_BIT); }
-  action operand2_16bit      { SET_OPERAND_TYPE(2, OPERAND_SIZE_16_BIT); }
-  action operand2_32bit      { SET_OPERAND_TYPE(2, OPERAND_SIZE_32_BIT); }
-  action operand2_64bit      { SET_OPERAND_TYPE(2, OPERAND_SIZE_64_BIT); }
-  action operand2_128bit     { SET_OPERAND_TYPE(2, OPERAND_SIZE_128_BIT); }
-  action operand2_256bit     { SET_OPERAND_TYPE(2, OPERAND_SIZE_256_BIT); }
-  action operand2_float32bit { SET_OPERAND_TYPE(2, OPERAND_FLOAT_SIZE_32_BIT); }
-  action operand2_float64bit { SET_OPERAND_TYPE(2, OPERAND_FLOAT_SIZE_64_BIT); }
-  action operand2_xmm        { SET_OPERAND_TYPE(2, OPERAND_XMM); }
-  action operand2_ymm        { SET_OPERAND_TYPE(2, OPERAND_YMM); }
+  action operand2_8bit       { SET_OPERAND_TYPE(2, OPERAND_TYPE_8_BIT); }
+  action operand2_16bit      { SET_OPERAND_TYPE(2, OPERAND_TYPE_16_BIT); }
+  action operand2_32bit      { SET_OPERAND_TYPE(2, OPERAND_TYPE_32_BIT); }
+  action operand2_64bit      { SET_OPERAND_TYPE(2, OPERAND_TYPE_64_BIT); }
+  action operand2_128bit     { SET_OPERAND_TYPE(2, OPERAND_TYPE_128_BIT); }
+  action operand2_256bit     { SET_OPERAND_TYPE(2, OPERAND_TYPE_256_BIT); }
+  action operand2_float32bit { SET_OPERAND_TYPE(2, OPERAND_TYPE_FLOAT_32_BIT); }
+  action operand2_float64bit { SET_OPERAND_TYPE(2, OPERAND_TYPE_FLOAT_64_BIT); }
+  action operand2_xmm        { SET_OPERAND_TYPE(2, OPERAND_TYPE_XMM); }
+  action operand2_ymm        { SET_OPERAND_TYPE(2, OPERAND_TYPE_YMM); }
 
-  action operand3_8bit       { SET_OPERAND_TYPE(3, OPERAND_SIZE_8_BIT); }
-  action operand3_128bit     { SET_OPERAND_TYPE(3, OPERAND_SIZE_128_BIT); }
-  action operand3_256bit     { SET_OPERAND_TYPE(3, OPERAND_SIZE_256_BIT); }
-  action operand3_float32bit { SET_OPERAND_TYPE(3, OPERAND_FLOAT_SIZE_32_BIT); }
-  action operand3_float64bit { SET_OPERAND_TYPE(3, OPERAND_FLOAT_SIZE_64_BIT); }
-  action operand3_xmm        { SET_OPERAND_TYPE(3, OPERAND_XMM); }
-  action operand3_ymm        { SET_OPERAND_TYPE(3, OPERAND_YMM); }
+  action operand3_8bit       { SET_OPERAND_TYPE(3, OPERAND_TYPE_8_BIT); }
+  action operand3_128bit     { SET_OPERAND_TYPE(3, OPERAND_TYPE_128_BIT); }
+  action operand3_256bit     { SET_OPERAND_TYPE(3, OPERAND_TYPE_256_BIT); }
+  action operand3_float32bit { SET_OPERAND_TYPE(3, OPERAND_TYPE_FLOAT_32_BIT); }
+  action operand3_float64bit { SET_OPERAND_TYPE(3, OPERAND_TYPE_FLOAT_64_BIT); }
+  action operand3_xmm        { SET_OPERAND_TYPE(3, OPERAND_TYPE_XMM); }
+  action operand3_ymm        { SET_OPERAND_TYPE(3, OPERAND_TYPE_YMM); }
 
-  action operand4_2bit       { SET_OPERAND_TYPE(4, OPERAND_SIZE_2_BIT); }
+  action operand4_2bit       { SET_OPERAND_TYPE(4, OPERAND_TYPE_2_BIT); }
 
   action operand0_ds_rbx     { SET_OPERAND_NAME(0, REG_DS_RBX); }
   action operand0_ds_rsi     { SET_OPERAND_NAME(0, REG_DS_RSI); }
   action operand0_es_rdi     { SET_OPERAND_NAME(0, REG_ES_RDI); }
   action operand0_immediate  { SET_OPERAND_NAME(0, REG_IMM); }
   action operand0_port_dx    { SET_OPERAND_NAME(0, REG_PORT_DX); }
   action operand0_rax        { SET_OPERAND_NAME(0, REG_RAX); }
   action operand0_rcx        { SET_OPERAND_NAME(0, REG_RCX); }
   action operand0_rdx        { SET_OPERAND_NAME(0, REG_RDX); }
   action operand0_rm         { SET_OPERAND_NAME(0, REG_RM); }
@@ skipping 43 matching lines @@
     SET_OPERAND_NAME(3, RegisterFromIS4(*current_position));
   }
 }%%
 
 %%{
   machine operand_actions_ia32;
 
   include operand_actions_common
     "native_client/src/trusted/validator_ragel/unreviewed/parse_instruction.rl";
 
-  action operand0_regsize {  SET_OPERAND_TYPE(0, OPERAND_SIZE_32_BIT); }
-  action operand1_regsize {  SET_OPERAND_TYPE(1, OPERAND_SIZE_32_BIT); }
-  action operand2_regsize {  SET_OPERAND_TYPE(2, OPERAND_SIZE_32_BIT); }
+  action operand0_regsize {  SET_OPERAND_TYPE(0, OPERAND_TYPE_32_BIT); }
+  action operand1_regsize {  SET_OPERAND_TYPE(1, OPERAND_TYPE_32_BIT); }
+  action operand2_regsize {  SET_OPERAND_TYPE(2, OPERAND_TYPE_32_BIT); }
 
   action operand0_absolute_disp {
     SET_OPERAND_NAME(0, REG_RM);
     SET_MODRM_BASE(NO_REG);
     SET_MODRM_INDEX(NO_REG);
     SET_MODRM_SCALE(0);
   }
   action operand0_from_modrm_reg {
     SET_OPERAND_NAME(0, RegFromModRM(*current_position));
   }
@@ skipping 37 matching lines @@
     SET_OPERAND_NAME(3, RMFromModRM(*current_position));
   }
 }%%
 
 %%{
   machine operand_actions_amd64;
 
   include operand_actions_common
     "native_client/src/trusted/validator_ragel/unreviewed/parse_instruction.rl";
 
-  action operand0_regsize {  SET_OPERAND_TYPE(0, OPERAND_SIZE_64_BIT); }
-  action operand1_regsize {  SET_OPERAND_TYPE(1, OPERAND_SIZE_64_BIT); }
-  action operand2_regsize {  SET_OPERAND_TYPE(2, OPERAND_SIZE_64_BIT); }
+  action operand0_regsize {  SET_OPERAND_TYPE(0, OPERAND_TYPE_64_BIT); }
+  action operand1_regsize {  SET_OPERAND_TYPE(1, OPERAND_TYPE_64_BIT); }
+  action operand2_regsize {  SET_OPERAND_TYPE(2, OPERAND_TYPE_64_BIT); }
 
   action operand0_absolute_disp {
     SET_OPERAND_NAME(0, REG_RM);
     SET_MODRM_BASE(NO_REG);
     SET_MODRM_INDEX(REG_RIZ);
     SET_MODRM_SCALE(0);
   }
   action operand0_from_modrm_reg {
     SET_OPERAND_NAME(0, RegFromModRM(*current_position) |
                         RegisterExtentionFromREX(GET_REX_PREFIX()) |
@@ skipping 500 matching lines @@
   action rel8_operand_end { }
   action rel16_operand_begin { }
   action rel16_operand_end { }
   action rel32_operand_begin { }
   action rel32_operand_end { }
 
   rel8  = any >rel8_operand_begin @rel8_operand_end;
   rel16 = any{2} @~rel16_operand_begin @rel16_operand_end;
   rel32 = any{4} @~rel32_operand_begin @rel32_operand_end;
 }%%
+
+%%{
+  machine decoder;
+
+  decoder = (one_instruction
+    @{
+        process_instruction(instruction_start, current_position+1, &instruction,
+                            userdata);
+        instruction_start = current_position + 1;
+        SET_DISP_TYPE(DISPNONE);
+        SET_IMM_TYPE(IMMNONE);
+        SET_IMM2_TYPE(IMMNONE);
+        SET_REX_PREFIX(FALSE);
+        SET_DATA16_PREFIX(FALSE);
+        SET_LOCK_PREFIX(FALSE);
+        SET_REPNZ_PREFIX(FALSE);
+        SET_REPZ_PREFIX(FALSE);
+        SET_BRANCH_NOT_TAKEN(FALSE);
+        SET_BRANCH_TAKEN(FALSE);
+        /* Top three bis of VEX2 are inverted: see AMD/Intel manual.  */
+        SET_VEX_PREFIX2(0xe0);
+        SET_VEX_PREFIX3(0x00);
+    })*
+    $!{ process_error(current_position, userdata);
+        result = FALSE;
+        goto error_detected;
+    };
+}%%