Move validator_x86_XX.rl out of unreviewed.

src/trusted/validator/x86/testing/enuminsts/ragel_tester.c

 /*
  * Copyright (c) 2012 The Native Client Authors. All rights reserved.
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 /*
  * ragel_tester.c
  * Implements a ragel decoder that can be used as a NaClEnumeratorDecoder.
  */
 #ifndef NACL_TRUSTED_BUT_NOT_TCB
 #error("This file is not meant for use in the TCB.")
 #endif
 
 #include "native_client/src/trusted/validator/x86/testing/enuminsts/enuminsts.h"
 
 #include <string.h>
 #include "native_client/src/trusted/validator/types_memory_model.h"
 #include "native_client/src/trusted/validator/x86/ncinstbuffer.h"
 #include "native_client/src/trusted/validator/x86/testing/enuminsts/str_utils.h"
-#include "native_client/src/trusted/validator_ragel/unreviewed/decoder.h"
+#include "native_client/src/trusted/validator_ragel/decoder.h"
 #include "native_client/src/trusted/validator_ragel/unreviewed/validator.h"
 
 #define kBufferSize 1024
 
 /* Defines the virtual table for the ragel decoder. */
 struct {
   /* The virtual table that implements this decoder. */
   NaClEnumeratorDecoder _base;
 } ragel_decoder;
 
@@ skipping 49 matching lines @@
                R15_MODIFIED | BPL_MODIFIED | SPL_MODIFIED |
                UNRESTRICTED_RBP_PROCESSED | UNRESTRICTED_RSP_PROCESSED |
                RESTRICTED_RSP_UNPROCESSED | RESTRICTED_RBP_UNPROCESSED)) {
     return FALSE;
   } else {
     return TRUE;
   }
 }
 
 void RagelInstruction(const uint8_t *begin, const uint8_t *end,
-                      struct instruction *instruction, void *userdata) {
+                      struct Instruction *instruction, void *userdata) {
   struct RagelDecodeState *rstate = (struct RagelDecodeState *)userdata;
   UNREFERENCED_PARAMETER(instruction);
   /* Only look at the first instruction. */
   if (rstate->valid_state) return;
   if (end > begin) {
     rstate->inst_num_bytes = (uint8_t)(end - begin);
     rstate->inst_name = instruction->name;
   } else {
     rstate->inst_num_bytes = 0;
   }
@@ skipping 46 matching lines @@
   if (RState.inst_is_legal) {
     uint8_t chunk[(NACL_ENUM_MAX_INSTRUCTION_BYTES + kBundleMask) &
                   ~kBundleMask];
 
     /* Copy the command.  */
     memcpy(chunk, enumerator->_itext, tempstate.inst_num_bytes);
     /* Fill the rest with HLTs.  */
     memset(chunk + tempstate.inst_num_bytes, 0xf4,
            sizeof(chunk) - tempstate.inst_num_bytes);
     res = ValidateChunkArch(chunk, sizeof(chunk), 0 /*options*/,
-                            &full_cpuid_features,
+                            &kFullCPUIDFeatures,
                             RagelValidateError, NULL);
     RState.inst_is_valid = res;
   }
 
 #undef DecodeChunkArch
 #undef ValidateChunkArch
 }
 
 /* Returns true if the instruction parsed a legal instruction. */
 static Bool RIsInstLegal(const NaClEnumerator* enumerator) {
@@ skipping 40 matching lines @@
   ragel_decoder._base._install_flag_fn = InstallFlag;
   ragel_decoder._base._get_inst_mnemonic_fn = RGetInstMnemonic;
   ragel_decoder._base._get_inst_num_operands_fn = NULL;
   ragel_decoder._base._get_inst_operands_text_fn = NULL;
   ragel_decoder._base._writes_to_reserved_reg_fn = NULL;
   ragel_decoder._base._maybe_inst_validates_fn = RIsInstValid;
   ragel_decoder._base._segment_validates_fn = NULL;
   ragel_decoder._base._usage_message = "Runs ragel to decode instructions.";
   return &ragel_decoder._base;
 }