Move validator_x86_XX.rl out of unreviewed.

src/trusted/validator_ragel/validator.h

 /*
  * Copyright (c) 2012 The Native Client Authors. All rights reserved.
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #ifndef NATIVE_CLIENT_SRC_TRUSTED_VALIDATOR_RAGEL_VALIDATOR_H_
 #define NATIVE_CLIENT_SRC_TRUSTED_VALIDATOR_RAGEL_VALIDATOR_H_
 
 #include "native_client/src/trusted/validator_ragel/decoder.h"
@@ skipping 58 matching lines @@
   /* Operations with %ebp must be followed with sandboxing immediately.  */
   RESTRICTED_RBP_UNPROCESSED    = 0x00080000,
   /* Attemp to "sandbox" %rbp without restricting it first.  */
   UNRESTRICTED_RBP_PROCESSED    = 0x00180000,
   /* Operations with %esp must be followed with sandboxing immediately.  */
   RESTRICTED_RSP_UNPROCESSED    = 0x00280000,
   /* Attemp to "sandbox" %rsp without restricting it first.  */
   UNRESTRICTED_RSP_PROCESSED    = 0x00380000,
   /* Operations with %r15 are forbidden.  */
   R15_MODIFIED                  = 0x00400000,
-  /* Operations with BPL are forbidden for compatibility with old validator.  */
-  BPL_MODIFIED                  = 0x00800000,
-  /* Operations with SPL are forbidden for compatibility with old validator.  */
-  SPL_MODIFIED                  = 0x01000000,
+  /* Operations with %xBP are forbidden. */
+  /* This includes %bpl for compatibility with old validator.  */
+  BP_MODIFIED                   = 0x00800000,
+  /* Operations with %xSP are forbidden. */
+  /* This includes %spl for compatibility with old validator.  */
+  SP_MODIFIED                   = 0x01000000,
   /* Bad call alignment: "call" must end at the end of the bundle.  */
   BAD_CALL_ALIGNMENT            = 0x02000000,
   /* Instruction is modifiable by nacl_dyncode_modify.  */
   MODIFIABLE_INSTRUCTION        = 0x08000000,
   /* Special instruction.  Uses different, non-standard validation rules.  */
   SPECIAL_INSTRUCTION           = 0x10000000,
   /* Some 3DNow! instructions use immediate byte as opcode extensions.  */
   LAST_BYTE_IS_NOT_IMMEDIATE    = 0x20000000,
   /* Bad jump target.  Note: in this case ptr points to jump target!  */
   BAD_JUMP_TARGET               = 0x40000000
@@ skipping 76 matching lines @@
  * Alternatively, if CALL_USER_CALLBACK_ON_EACH_INSTRUCTION flag in options is
  * set, user_callback is called for every instruction.
  * If PROCESS_CHUNK_AS_A_CONTIGUOUS_STREAM flag in options is set,
  * instructions crossing bundle boundaries are not considered erroneous.
  *
  * Actually validation result is computed as conjunction of values returned
  * by all invocations of user_callback, so custom validation logic can be
  * placed there.
  */
 DLLEXPORT
-Bool ValidateChunkAMD64(const uint8_t *data, size_t size,
+Bool ValidateChunkAMD64(const uint8_t codeblock[],
+                        size_t size,
                         uint32_t options,
                         const NaClCPUFeaturesX86 *cpu_features,
                         ValidationCallbackFunc user_callback,
                         void *callback_data);
 
 /*
  * See ValidateChunkAMD64
  */
 DLLEXPORT
-Bool ValidateChunkIA32(const uint8_t *data, size_t size,
+Bool ValidateChunkIA32(const uint8_t codeblock[],
+                       size_t size,
                        uint32_t options,
                        const NaClCPUFeaturesX86 *cpu_features,
                        ValidationCallbackFunc user_callback,
                        void *callback_data);
 
 EXTERN_C_END
 
 #endif  /* NATIVE_CLIENT_SRC_TRUSTED_VALIDATOR_RAGEL_VALIDATOR_H_ */