Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(488)

Issue 1100003: Pass license check script for most of the tree. (Closed)

Created:
10 years, 9 months ago by Evan Martin
Modified:
9 years, 7 months ago
Reviewers:
agl, M-A Ruel
CC:
chromium-reviews, fbarchard, Alpha Left Google, pam+watch_chromium.org, awong, darin-cc_chromium.org, scherkus (not reviewing)
Visibility:
Public.

Description

Pass license check script for most of the tree. Modified license-checker script to allow pruning directories we know to be ok. Still need to do a bit of third_party/* , as well as file a bunch of bugs on pieces where the licenses aren't clear, but I'm running out of energy. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=42045

Patch Set 1 #

Patch Set 2 : more #

Total comments: 5

Patch Set 3 : retry #

Unified diffs Side-by-side diffs Delta from patch set Stats (+317 lines, -79 lines) Patch
M chrome/third_party/jstemplate/README.chromium View 1 chunk +3 lines, -2 lines 0 comments Download
A net/third_party/nss/LICENSE View 1 chunk +35 lines, -0 lines 0 comments Download
M net/third_party/nss/README.chromium View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/apple/README.chromium View 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/bsdiff/README.chromium View 1 chunk +4 lines, -3 lines 0 comments Download
M third_party/bspatch/LICENSE View 1 chunk +121 lines, -1 line 0 comments Download
M third_party/bspatch/README.chromium View 1 chunk +4 lines, -3 lines 0 comments Download
M third_party/bzip2/README.chromium View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/codesighs/README.chromium View 1 chunk +4 lines, -3 lines 0 comments Download
M third_party/expat/README.chromium View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/ffmpeg/README.chromium View 1 chunk +4 lines, -0 lines 0 comments Download
third_party/harfbuzz/README.chromium View 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/jemalloc/README.chromium View 1 chunk +41 lines, -38 lines 0 comments Download
M third_party/lcov/README.chromium View 1 chunk +4 lines, -3 lines 0 comments Download
A third_party/libevent/LICENSE View 1 chunk +24 lines, -0 lines 0 comments Download
M third_party/libevent/README.chromium View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/libjpeg/README.chromium View 1 chunk +3 lines, -0 lines 0 comments Download
third_party/libxml/README.chromium View 1 chunk +5 lines, -2 lines 0 comments Download
M third_party/libxslt/README.chromium View 1 chunk +5 lines, -2 lines 0 comments Download
M third_party/ocmock/README.chromium View 1 chunk +2 lines, -1 line 0 comments Download
A + third_party/simplejson/README.chromium View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/zlib/README.chromium View 2 chunks +3 lines, -3 lines 0 comments Download
M tools/licenses.py View 4 chunks +41 lines, -8 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Evan Martin
10 years, 9 months ago (2010-03-18 23:46:18 UTC) #1
Evan Martin
grr, rerunning upload isn't making the letters appear. it seems the diffs are ok though?
10 years, 9 months ago (2010-03-19 00:18:11 UTC) #2
M-A Ruel
10 years, 9 months ago (2010-03-19 00:37:43 UTC) #3
still lgtm

http://codereview.chromium.org/1100003/diff/3001/4016
File third_party/libevent/README.chromium (right):

http://codereview.chromium.org/1100003/diff/3001/4016#newcode3
third_party/libevent/README.chromium:3:
http://www.monkey.org/~provos/libevent-1.4.13-stable.tar.gz
Is it necessary, the others don't reference the tar directly.

http://codereview.chromium.org/1100003/diff/3001/4020
File third_party/ocmock/README.chromium (right):

http://codereview.chromium.org/1100003/diff/3001/4020#newcode3
third_party/ocmock/README.chromium:3:
http://svn.mulle-kybernetik.com/OCMock/trunk/Source/@55
Same

http://codereview.chromium.org/1100003/diff/3001/4023
File tools/licenses.py (right):

http://codereview.chromium.org/1100003/diff/3001/4023#newcode14
tools/licenses.py:14: PRUNE_PATHS = set([
Why a set, isn't it overkill?
nit: I'd prefer EXCLUDED_PATHS but I don't mind too much.

http://codereview.chromium.org/1100003/diff/3001/4023#newcode53
tools/licenses.py:53: line = line.strip()
insert:
if not line:
  break

http://codereview.chromium.org/1100003/diff/3001/4023#newcode100
tools/licenses.py:100: skip_dirs = ('.svn', '.git',             # VCS metadata
I'd move that beside PRUNE_PATHS.

Powered by Google App Engine
This is Rietveld 408576698