Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Issue 1100002: String search performance improvements: (Closed)

Created:
10 years, 9 months ago by Vitaly Repeshko
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

String search performance improvements: * Using memchr for first/only char lookup is faster than hand-coded loop. It processes one machine word per iteration so it helps even more on x64. * Tweaked badness computation in simple search. We pay only for the first char memchr scans, not for all of them. Committed: http://code.google.com/p/v8/source/detail?r=4173

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -2 lines) Patch
M src/runtime.cc View 3 chunks +29 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Vitaly Repeshko
10 years, 9 months ago (2010-03-18 08:52:07 UTC) #1
Mads Ager (chromium)
LGTM!
10 years, 9 months ago (2010-03-18 08:58:52 UTC) #2
Lasse Reichstein
10 years, 9 months ago (2010-03-18 09:02:42 UTC) #3
L-very-GTM too!

Powered by Google App Engine
This is Rietveld 408576698