Move forms/ out of webkit/.

content/public/renderer/password_form_dom_manager.h

+// Copyright (c) 2011 The Chromium Authors. All rights reserved.

[jam, 2012/10/02 16:18:14]

looks like svn history is lost?

[blundell, 2012/10/03 15:06:07]

Fixed. Note that the history of password_form_dom_manager is attached to
password_form_fill_data, as those files are more similar content-wise to the old
password_form_dom_manager files than these files are.

On 2012/10/02 16:18:14, John Abd-El-Malek wrote:

+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CONTENT_PUBLIC_RENDERER_PASSWORD_FORM_DOM_MANAGER_H_
+#define CONTENT_PUBLIC_RENDERER_PASSWORD_FORM_DOM_MANAGER_H_
+
+#include <map>
+
+#include "base/memory/scoped_ptr.h"
+#include "content/common/content_export.h"
+#include "content/public/common/password_form.h"
+#include "content/public/common/password_form_fill_data.h"
+#include "third_party/WebKit/Source/WebKit/chromium/public/WebPasswordFormData.h"

[jam, 2012/10/02 16:18:14]

please forward declare as much as possible

[blundell, 2012/10/03 15:06:07]

Done.

+
+namespace content {
+
+class PasswordFormDomManager {
+ public:
+  // Create a PasswordForm from DOM form. Webkit doesn't allow storing
+  // custom metadata to DOM nodes, so we have to do this every time an event
+  // happens with a given form and compare against previously Create'd forms
+  // to identify..which sucks.
+  CONTENT_EXPORT static scoped_ptr<PasswordForm> CreatePasswordForm(
+      const WebKit::WebFormElement& form);

[jam, 2012/10/02 16:18:14]

the content api, like the webkit api, doesn't use a class for scoping a static
method. just keep this as a static method in the content namespace. the cc file
should be in content/renderer/password_form_dom_manager.h

[blundell, 2012/10/03 15:06:07]

Done. Also gave the file what seems like a more appropriate name at this point.

+
+ private:
+  DISALLOW_IMPLICIT_CONSTRUCTORS(PasswordFormDomManager);
+};
+
+}  // namespace content
+
+#endif  // CONTENT_PUBLIC_RENDERER_PASSWORD_FORM_DOM_MANAGER_H__