Android: adds Get(Static)MethodIDOrNULL.

chrome/browser/history/android/sqlite_cursor.cc

Index: chrome/browser/history/android/sqlite_cursor.cc
diff --git a/chrome/browser/history/android/sqlite_cursor.cc b/chrome/browser/history/android/sqlite_cursor.cc
index 786e157c7e090978b5666162fbdaaa71adb2b1d2..8de713d8afca09e90866ae74bd637f1edfa18c52 100644
--- a/chrome/browser/history/android/sqlite_cursor.cc
+++ b/chrome/browser/history/android/sqlite_cursor.cc
@@ -16,7 +16,6 @@
 using base::android::ConvertUTF8ToJavaString;
 using base::android::GetClass;
 using base::android::HasClass;
-using base::android::HasMethod;
 using base::android::GetMethodID;
 using base::android::ScopedJavaLocalRef;
 using content::BrowserThread;
@@ -62,12 +61,9 @@ ScopedJavaLocalRef<jobject> SQLiteCursor::NewJavaSqliteCursor(
   }
 
   ScopedJavaLocalRef<jclass> sclass = GetClass(env, kSQLiteCursorClassPath);
-  if (!HasMethod(env, sclass, "<init>", "(I)V")) {

[nyquist, 2012/10/02 02:59:17]

See RHS of review

[bulach, 2012/10/02 08:19:22]

Done.

-    LOG(ERROR) << "Can not find " << kSQLiteCursorClassPath << " Constructor";
-    return ScopedJavaLocalRef<jobject>();
-  }
 
   jmethodID method_id = GetMethodID(env, sclass, "<init>", "(I)V");

[nyquist, 2012/10/02 02:59:17]

Could we do GetMethodIDOrNull(...) here, and then do add the old lines 66-67:

  LOG(ERROR) << "Can not find " << kSQLiteCursorClassPath << " Constructor";
  return ScopedJavaLocalRef<jobject>();

That requires adding the JavaRef<jclass> version of
base::android::GetMethodIDOrNull though. But at least we will then not change
any behavior.

[bulach, 2012/10/02 08:19:22]

joth points out that this constructor has always been available on all API
levels.. I think this check was one of those "just in case" checks we sprinkled
ages ago..
his comments:
http://codereview.chromium.org/10996063/diff/3009/chrome/browser/history/andr...


but tbh, since this patch no longer removes the HasMethod, I'll revert this file
and then will address this later on.

+
   SQLiteCursor* cursor = new SQLiteCursor(column_names, statement, service,
                                           favicon_service);
   ScopedJavaLocalRef<jobject> obj(env,