Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1190)

Unified Diff: base/test/test_shortcut_win.h

Issue 10996005: Use gtest failures and EXPECTS instead of returning a failure enum in test target base/test/test_sh… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: No ASSERTs in test support targets Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/test/test_shortcut_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/test/test_shortcut_win.h
diff --git a/base/test/test_shortcut_win.h b/base/test/test_shortcut_win.h
index cb5b2c392213d22e74163d6572d3f4c393e79e43..ef75713e366e39e56263fb9c38a1f1187e29fa72 100644
--- a/base/test/test_shortcut_win.h
+++ b/base/test/test_shortcut_win.h
@@ -13,24 +13,11 @@
namespace base {
namespace win {
-enum VerifyShortcutStatus {
- VERIFY_SHORTCUT_SUCCESS = 0,
- VERIFY_SHORTCUT_FAILURE_UNEXPECTED,
- VERIFY_SHORTCUT_FAILURE_FILE_NOT_FOUND,
- VERIFY_SHORTCUT_FAILURE_TARGET,
- VERIFY_SHORTCUT_FAILURE_WORKING_DIR,
- VERIFY_SHORTCUT_FAILURE_ARGUMENTS,
- VERIFY_SHORTCUT_FAILURE_DESCRIPTION,
- VERIFY_SHORTCUT_FAILURE_ICON,
- VERIFY_SHORTCUT_FAILURE_APP_ID,
- VERIFY_SHORTCUT_FAILURE_DUAL_MODE,
-};
-
-// Verify that a shortcut exists at |shortcut_path| with the expected
+// Validates that a shortcut exists at |shortcut_path| with the expected
// |properties|.
-VerifyShortcutStatus VerifyShortcut(const FilePath& shortcut_path,
- const ShortcutProperties& properties);
-
+// Logs gtest failures on failed verifications.
+void ValidateShortcut(const FilePath& shortcut_path,
+ const ShortcutProperties& properties);
} // namespace win
} // namespace base
« no previous file with comments | « no previous file | base/test/test_shortcut_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698