Handle titlebar text updates properly

ui/views/widget/widget.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/widget/widget.h"
 
 #include "base/logging.h"
 #include "base/message_loop.h"
 #include "base/utf_string_conversions.h"
 #include "ui/base/events/event.h"
@@ skipping 719 matching lines @@
 
 void* Widget::GetNativeWindowProperty(const char* name) const {
   return native_widget_->GetNativeWindowProperty(name);
 }
 
 void Widget::UpdateWindowTitle() {
   if (!non_client_view_)
     return;
 
   // If the non-client view is rendering its own title, it'll need to relayout
-  // now.
+  // now and to get a paint update later on.
   non_client_view_->Layout();
+  non_client_view_->UpdateWindowTitle();

[sky, 2012/09/28 22:47:12]

Don't you need to do all this after updating the native_widget_'s title? If you
call this before updating the native title then anyone that asks for the updated
window title won't get the right thing.

Additionally you should Layout() after updating the window title, since that may
cause things to need a bigger size.

[Mr4D (OOO till 08-26), 2012/09/29 00:44:25]

Okay. Changed. Not sure if this might cause problems though since it looked like
that there was a reason for the order.

But tested it in various situations and it worked.

 
   // Update the native frame's text. We do this regardless of whether or not
   // the native frame is being used, since this also updates the taskbar, etc.
   string16 window_title;
   if (native_widget_->IsScreenReaderActive()) {
     window_title = widget_delegate_->GetAccessibleWindowTitle();
   } else {
     window_title = widget_delegate_->GetWindowTitle();
   }
   base::i18n::AdjustStringForLocaleDirection(&window_title);
@@ skipping 594 matching lines @@
 
 ////////////////////////////////////////////////////////////////////////////////
 // internal::NativeWidgetPrivate, NativeWidget implementation:
 
 internal::NativeWidgetPrivate* NativeWidgetPrivate::AsNativeWidgetPrivate() {
   return this;
 }
 
 }  // namespace internal
 }  // namespace views