Handle titlebar text updates properly

chrome/browser/ui/views/frame/opaque_browser_frame_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/frame/opaque_browser_frame_view.h"
 
 #include <algorithm>
 #include <string>
 
 #include "base/command_line.h"
@@ skipping 359 matching lines @@
   restore_button_->SetState(views::CustomButton::BS_NORMAL);
   minimize_button_->SetState(views::CustomButton::BS_NORMAL);
   maximize_button_->SetState(views::CustomButton::BS_NORMAL);
   // The close button isn't affected by this constraint.
 }
 
 void OpaqueBrowserFrameView::UpdateWindowIcon() {
   window_icon_->SchedulePaint();
 }
 
+void OpaqueBrowserFrameView::UpdateWindowTitle() {
+  if (!frame()->IsFullscreen())
+    SchedulePaintInRect(title_bounds_);

[msw, 2012/09/28 20:10:51]

This particular implementation may be unnecessary after http://crrev.com/159087,
but I haven't looked closely at this patch.

Now, a views::Label title schedules a paint internally on text changes, etc.
I'd favor a solution of using more Labels titles in NonClientView, if possible.
Standard views components should simplify these common critical tasks.

[Mr4D (OOO till 08-26), 2012/09/28 20:30:48]

This particular: You may be right. I was adding this since I am not sure how
many broken cases we have. So I might be able to remove this.

for views::Label - well - there are several different things being used,
dependent on which frame you are looking: there is a frame_painter, there are
labels and there are self drawing frames. But instead of adding another Label
object to every frame object it might be easier to simplify the entire frame
handling. (not with this CL for sure - especially because this CL is targetted
towards M23).

[msw, 2012/09/28 20:42:51]

Okay, let me know if you'd like my full review here or help with any followup.

+}
+
 ///////////////////////////////////////////////////////////////////////////////
 // OpaqueBrowserFrameView, views::View overrides:
 
 void OpaqueBrowserFrameView::OnPaint(gfx::Canvas* canvas) {
   if (frame()->IsFullscreen())
     return;  // Nothing is visible, so don't bother to paint.
 
   if (frame()->IsMaximized())
     PaintMaximizedFrameBorder(canvas);
   else
@@ skipping 657 matching lines @@
 
 gfx::Rect OpaqueBrowserFrameView::CalculateClientAreaBounds(int width,
                                                             int height) const {
   int top_height = NonClientTopBorderHeight(false);
   int border_thickness = NonClientBorderThickness();
   return gfx::Rect(border_thickness, top_height,
                    std::max(0, width - (2 * border_thickness)),
                    std::max(0, height - GetReservedHeight() -
                        top_height - border_thickness));
 }