Use extensions socket permission for TCP/UDP socket APIs in Pepper

content/public/browser/content_browser_client.h

Index: content/public/browser/content_browser_client.h
diff --git a/content/public/browser/content_browser_client.h b/content/public/browser/content_browser_client.h
index 7c55235a193c638264456bdcf245ed43d82ce51d..644bc917aba02669c2c90b78bba78cd19e5844aa 100644
--- a/content/public/browser/content_browser_client.h
+++ b/content/public/browser/content_browser_client.h
@@ -83,6 +83,28 @@ struct ShowDesktopNotificationHostMsgParams;
 // the observer interfaces.)
 class CONTENT_EXPORT ContentBrowserClient {
  public:
+  struct SocketPermissionParam {

[jam, 2012/10/10 20:48:30]

please move this to a separate file (the convention in the content api is that
every struct or class should be in a separate file)

also, it seems unfortunate that this duplicates a subset of the
SocketPermissionData structure in chrome. can the latter be made to contain this
struct and add whatever other data it needs to it?

[Dmitry Polukhin, 2012/10/17 09:25:54]

Done.
I agree that it looks unfortunate to have this duplication. But if extension
internals use things from content, it also looks a bit strange to me and any
change there will require OWNER LGTM from content... But I'll switch extensions
code to content::SocketPermissionRequest if extensions team is OK with it.

[jam, 2012/10/17 15:22:42]

why do you say it's odd? extensions is in chrome, which depends on content (i.e.
like it depends on base). extensions code uses many objects from content
already.

[Dmitry Polukhin, 2012/10/18 08:57:38]

** Presubmit ERRORS **
You added one or more #includes that violate checkdeps rules.
  chrome/common/extensions/permissions/socket_permission_data.h
      Illegal include: "content/public/browser/socket_permission_request.h"
    Because of no rule applying.

Is it legal inclusion and I should add some checkdeps rule to remove this error?

[jam, 2012/10/18 15:37:15]

this is because chrome\common is including from content\public\browser, which
isn't allowed. just move the new header to content\public\common instead

+    enum OperationType {
+      NONE = 0,
+      TCP_CONNECT,
+      TCP_LISTEN,
+      UDP_BIND,
+      UDP_SEND_TO,
+    };
+
+    SocketPermissionParam(OperationType type,
+                          const std::string& host,
+                          int port)
+      : type(type),
+        host(host),
+        port(port) {
+    }
+
+    OperationType type;
+    std::string host;
+    int port;
+  };
+
   virtual ~ContentBrowserClient() {}
 
   // Allows the embedder to set any number of custom BrowserMainParts
@@ -442,9 +464,10 @@ class CONTENT_EXPORT ContentBrowserClient {
   virtual void DidCreatePpapiPlugin(BrowserPpapiHost* browser_host) {}
 
   // Returns true if renderer processes can use Pepper TCP/UDP sockets from
-  // the given origin.
+  // the given origin and connection type.
   virtual bool AllowPepperSocketAPI(BrowserContext* browser_context,
-                                    const GURL& url);
+                                    const GURL& url,
+                                    const SocketPermissionParam& params);
 
   // Returns true if renderer processes can use private Pepper File APIs.
   virtual bool AllowPepperPrivateFileAPI();