Issue 10992: Implement $ for non-multiline.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10992: Implement $ for non-multiline. (Closed)

Created:
12 years ago by Erik Corry

Modified:
9 years, 7 months ago

Reviewers:
Christian Plesner Hansen

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Implement $ for non-multiline. Committed: http://code.google.com/p/v8/source/detail?r=862

Patch Set 1 #

Created: 12 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+195 lines, -71 lines)			Patch
M	src/assembler-irregexp.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/assembler-irregexp.cc	View	1 chunk	+10 lines, -0 lines	0 comments	Download
M	src/bytecodes-irregexp.h	View	1 chunk	+7 lines, -6 lines	0 comments	Download
M	src/flag-definitions.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/interpreter-irregexp.cc	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	src/jsregexp.h	View	3 chunks	+10 lines, -6 lines	0 comments	Download
M	src/jsregexp.cc	View	15 chunks	+105 lines, -58 lines	1 comment	Download
M	src/regexp-macro-assembler.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/regexp-macro-assembler-ia32.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/regexp-macro-assembler-ia32.cc	View	1 chunk	+10 lines, -0 lines	0 comments	Download
M	src/regexp-macro-assembler-irregexp.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/regexp-macro-assembler-irregexp.cc	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	src/regexp-macro-assembler-tracer.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/regexp-macro-assembler-tracer.cc	View	1 chunk	+12 lines, -0 lines	0 comments	Download
M	test/cctest/test-regexp.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/mjsunit/regexp.js	View	1 chunk	+20 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Christian Plesner Hansen

12 years ago (2008-11-28 08:44:53 UTC) #2

Stv!

http://codereview.chromium.org/10992/diff/1/16
File src/jsregexp.cc (right):

http://codereview.chromium.org/10992/diff/1/16#newcode2342
Line 2342: // TODO(erikcorry): A back reference has to have two successors (by
default
I wonder if maybe we always have to propagate to the on-failure continuation. 
In most cases it will be a backtrack node and it won't matter, but it may not be
and in that case we must propagate.

Expand Messages | Collapse Messages