Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1693)

Unified Diff: ash/wm/power_button_controller.cc

Issue 10990118: Polish lock animation - launcher should do a fade out. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Move launcher container up Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/wm/power_button_controller.cc
diff --git a/ash/wm/power_button_controller.cc b/ash/wm/power_button_controller.cc
index 621b24a7fd7a47e937f2678ce88982e12400afdc..0667345b0544f9727af730dba2e87eaf8e025f5c 100644
--- a/ash/wm/power_button_controller.cc
+++ b/ash/wm/power_button_controller.cc
@@ -169,6 +169,11 @@ void GetContainers(int container_mask, aura::Window::Windows* containers) {
root_window,
internal::kShellWindowId_DesktopBackgroundContainer));
}
+ if (container_mask & PowerButtonController::LAUNCHER) {
+ containers->push_back(Shell::GetContainer(
+ root_window,
+ internal::kShellWindowId_LauncherContainer));
+ }
if (container_mask & PowerButtonController::NON_LOCK_SCREEN_CONTAINERS) {
containers->push_back(Shell::GetContainer(
root_window,
@@ -283,6 +288,7 @@ gfx::Rect PowerButtonController::TestApi::GetBlackLayerBounds() const {
// static
int PowerButtonController::GetAllContainersMask() {
return PowerButtonController::DESKTOP_BACKGROUND |
+ PowerButtonController::LAUNCHER |
PowerButtonController::NON_LOCK_SCREEN_CONTAINERS |
GetAllLockScreenContainersMask();
}
@@ -353,7 +359,7 @@ void PowerButtonController::OnLockStateChanged(bool locked) {
this, &PowerButtonController::OnLockToShutdownTimeout);
}
} else {
- StartAnimation(DESKTOP_BACKGROUND | NON_LOCK_SCREEN_CONTAINERS,
+ StartAnimation(DESKTOP_BACKGROUND | LAUNCHER | NON_LOCK_SCREEN_CONTAINERS,
ANIMATION_RESTORE);
HideBlackLayer();
}
@@ -372,6 +378,8 @@ void PowerButtonController::OnStartingLock() {
// as part of the slow-close animation.
ShowBlackLayer();
+ StartAnimation(LAUNCHER, ANIMATION_HIDE);
+
StartAnimation(NON_LOCK_SCREEN_CONTAINERS, ANIMATION_FAST_CLOSE);
// Hide the screen locker containers so we can make them fade in later.
@@ -510,7 +518,7 @@ void PowerButtonController::OnLockTimeout() {
void PowerButtonController::OnLockFailTimeout() {
DCHECK_NE(login_status_, user::LOGGED_IN_LOCKED);
LOG(ERROR) << "Screen lock request timed out";
- StartAnimation(NON_LOCK_SCREEN_CONTAINERS, ANIMATION_RESTORE);
+ StartAnimation(LAUNCHER | NON_LOCK_SCREEN_CONTAINERS, ANIMATION_RESTORE);
HideBlackLayer();
}
@@ -560,7 +568,7 @@ void PowerButtonController::StartShutdownAnimationAndRequestShutdown() {
// Hide the other containers before starting the animation.
// ANIMATION_FAST_CLOSE will make the screen locker windows partially
// transparent, and we don't want the other windows to show through.
- StartAnimation(NON_LOCK_SCREEN_CONTAINERS, ANIMATION_HIDE);
+ StartAnimation(LAUNCHER | NON_LOCK_SCREEN_CONTAINERS, ANIMATION_HIDE);
StartAnimation(GetAllLockScreenContainersMask(), ANIMATION_FAST_CLOSE);
} else {
StartAnimation(GetAllContainersMask(), ANIMATION_FAST_CLOSE);

Powered by Google App Engine
This is Rietveld 408576698