Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Unified Diff: media/base/video_decoder.h

Issue 10990039: Enforce Stop() is always called before dtor in FFmepgVideoDecoder. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | media/filters/ffmpeg_video_decoder.h » ('j') | media/filters/ffmpeg_video_decoder_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/video_decoder.h
diff --git a/media/base/video_decoder.h b/media/base/video_decoder.h
index b22b14438d7c7add198a778cbc0aaf1443f9454f..091cc052846ffe8ee575c0607ecba214a957bc7c 100644
--- a/media/base/video_decoder.h
+++ b/media/base/video_decoder.h
@@ -55,8 +55,10 @@ class MEDIA_EXPORT VideoDecoder
// clean state.
virtual void Reset(const base::Closure& closure) = 0;
- // Stop decoder and set it to an uninitialized state. Note that a VideoDecoder
- // should/could not be re-initialized after it has been stopped.
+ // Stops decoder and sets it to an uninitialized state. Note that a
+ // VideoDecoder cannot be re-initialized after it has been stopped.
+ // If the VideoDecoder has been initialized, Stop() must be called before the
scherkus (not reviewing) 2012/09/25 20:58:16 /must be called/must complete/
scherkus (not reviewing) 2012/09/25 20:58:16 s/VideoDecoder/decoder/
Ami GONE FROM CHROMIUM 2012/09/25 21:18:26 Initialize() is async; "has been initialized" is u
xhwang 2012/09/26 01:09:58 Done.
xhwang 2012/09/26 01:09:58 Done.
+ // VideoDecoder can be destructed.
scherkus (not reviewing) 2012/09/25 20:58:16 s/the VideoDecoder can be destructed/deleting the
xhwang 2012/09/26 01:09:58 Done.
virtual void Stop(const base::Closure& closure) = 0;
// Returns true if the output format has an alpha channel. Most formats do not
« no previous file with comments | « no previous file | media/filters/ffmpeg_video_decoder.h » ('j') | media/filters/ffmpeg_video_decoder_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698