Enforce Stop() is always called before dtor in FFmepgVideoDecoder.

media/base/video_decoder.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef MEDIA_BASE_VIDEO_DECODER_H_
 #define MEDIA_BASE_VIDEO_DECODER_H_
 
 #include "base/callback.h"
 #include "base/memory/ref_counted.h"
 #include "media/base/pipeline_status.h"
@@ skipping 37 matching lines @@
   // NULL video frames indicate an aborted read. This can happen if the
   // DemuxerStream gets flushed and doesn't have any more data to return.
   typedef base::Callback<void(Status, const scoped_refptr<VideoFrame>&)> ReadCB;
   virtual void Read(const ReadCB& read_cb) = 0;
 
   // Reset decoder state, fulfilling all pending ReadCB and dropping extra
   // queued decoded data. After this call, the decoder is back to an initialized
   // clean state.
   virtual void Reset(const base::Closure& closure) = 0;
 
-  // Stop decoder and set it to an uninitialized state. Note that a VideoDecoder
-  // should/could not be re-initialized after it has been stopped.
+  // Stops decoder and sets it to an uninitialized state. Note that a
+  // VideoDecoder cannot be re-initialized after it has been stopped.
+  // If the VideoDecoder has been initialized, Stop() must be called before the

[scherkus (not reviewing), 2012/09/25 20:58:16]

/must be called/must complete/

[scherkus (not reviewing), 2012/09/25 20:58:16]

s/VideoDecoder/decoder/

[Ami GONE FROM CHROMIUM, 2012/09/25 21:18:26]

Initialize() is async; "has been initialized" is unknowable by the caller. 
Replace with
If Initialize() has been called, Stop() must be called...
?

[xhwang, 2012/09/26 01:09:58]

Done.

[xhwang, 2012/09/26 01:09:58]

Done.

+  // VideoDecoder can be destructed.

[scherkus (not reviewing), 2012/09/25 20:58:16]

s/the VideoDecoder can be destructed/deleting the decoder/

[xhwang, 2012/09/26 01:09:58]

Done.

   virtual void Stop(const base::Closure& closure) = 0;
 
   // Returns true if the output format has an alpha channel. Most formats do not
   // have alpha so the default is false. Override and return true for decoders
   // that return formats with an alpha channel.
   virtual bool HasAlpha() const;
 
  protected:
   friend class base::RefCountedThreadSafe<VideoDecoder>;
   virtual ~VideoDecoder();
   VideoDecoder();
 
   DISALLOW_COPY_AND_ASSIGN(VideoDecoder);
 };
 
 }  // namespace media
 
 #endif  // MEDIA_BASE_VIDEO_DECODER_H_