chrome/renderer/chrome_content_renderer_client.cc - Issue 10990038: Grant popup blocker bypass based upon extension context type.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/chrome_content_renderer_client.cc

Issue 10990038: Grant popup blocker bypass based upon extension context type. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/chrome_content_renderer_client.cc

===================================================================

--- chrome/renderer/chrome_content_renderer_client.cc (revision 158606)

+++ chrome/renderer/chrome_content_renderer_client.cc (working copy)

@@ -725,7 +725,8 @@

bool ChromeContentRendererClient::AllowPopup(const GURL& creator) {

extensions::ChromeV8Context* current_context =

extension_dispatcher_->v8_context_set().GetCurrent();

- return current_context && current_context->extension();

+ return current_context && current_context->extension() &&

+ current_context->context_type() != extensions::Feature::WEB_PAGE_CONTEXT;

Aaron Boodman 2012/09/25 21:42:57 A whitelist would be better. == BLESSED_EXTENSION_

}

bool ChromeContentRendererClient::ShouldFork(WebFrame* frame,

« no previous file with comments | « chrome/browser/extensions/app_process_apitest.cc ('k') | no next file » | no next file with comments »