Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Issue 10989066: Move favicon image files to ui/resources common folder. (Closed)

Created:
8 years, 2 months ago by newt (away)
Modified:
8 years, 2 months ago
Reviewers:
oshima
CC:
chromium-reviews, oshima+watch_chromium.org, Sebastien Gabriel
Visibility:
Public.

Description

Move favicon image files to ui/resources common folder.

Patch Set 1 #

Messages

Total messages: 8 (0 generated)
newt (away)
PTAL
8 years, 2 months ago (2012-09-27 23:27:40 UTC) #1
oshima
On 2012/09/27 23:27:40, newt wrote: > PTAL One question while waiting for sebastian's reply. I ...
8 years, 2 months ago (2012-10-01 19:22:26 UTC) #2
newt (away)
On 2012/10/01 19:22:26, oshima wrote: > On 2012/09/27 23:27:40, newt wrote: > > PTAL > ...
8 years, 2 months ago (2012-10-02 09:31:28 UTC) #3
oshima
On 2012/10/02 09:31:28, newt wrote: > On 2012/10/01 19:22:26, oshima wrote: > > On 2012/09/27 ...
8 years, 2 months ago (2012-10-02 20:09:07 UTC) #4
newt (away)
Does this lgty now?
8 years, 2 months ago (2012-10-08 14:23:01 UTC) #5
oshima
On 2012/10/08 14:23:01, newt wrote: > Does this lgty now? lgtm
8 years, 2 months ago (2012-10-08 17:06:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/newt@chromium.org/10989066/1
8 years, 2 months ago (2012-10-08 17:13:24 UTC) #7
commit-bot: I haz the power
8 years, 2 months ago (2012-10-08 17:13:27 UTC) #8
Can't process patch for file
ui/resources/default_100_percent/common/default_favicon_64.png.
Binary file support is temporarilly disabled due to a bug. Please commit blindly
the binary files first then commit the source change as a separate CL. Sorry for
the annoyance.

Powered by Google App Engine
This is Rietveld 408576698